Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Unified Diff: chrome/browser/extensions/bundle_installer.cc

Issue 501273002: Update extension install prompt to reflect withheld permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added init calls for other types of installs Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/bundle_installer.cc
diff --git a/chrome/browser/extensions/bundle_installer.cc b/chrome/browser/extensions/bundle_installer.cc
index fcd6adade518c588abee2e63bc042edff8bf37f7..6caeee2da6f570eca2a324f18a5f40a79bdf85ee 100644
--- a/chrome/browser/extensions/bundle_installer.cc
+++ b/chrome/browser/extensions/bundle_installer.cc
@@ -13,6 +13,7 @@
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
#include "chrome/browser/extensions/crx_installer.h"
+#include "chrome/browser/extensions/permissions_updater.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_finder.h"
@@ -255,7 +256,11 @@ void BundleInstaller::ShowPrompt() {
}
scoped_refptr<PermissionSet> permissions;
+ PermissionsUpdater updater(profile_);
for (size_t i = 0; i < dummy_extensions_.size(); ++i) {
+ // Initialize permissions so that withheld permissions don't end up in the
+ // install prompt.
+ updater.InitializePermissions(dummy_extensions_[i]);
permissions = PermissionSet::CreateUnion(
permissions.get(),
dummy_extensions_[i]->permissions_data()->active_permissions());

Powered by Google App Engine
This is Rietveld 408576698