Update extension install prompt to reflect withheld permissions

chrome/browser/extensions/bundle_installer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/bundle_installer.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/i18n/rtl.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/crx_installer.h"
+#include "chrome/browser/extensions/permissions_updater.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/grit/generated_resources.h"
 #include "content/public/browser/web_contents.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/permissions/permission_set.h"
@@ skipping 19 matching lines @@
   // We require localized names so we can have nice error messages when we can't
   // parse an extension manifest.
   CHECK(!item.localized_name.empty());
 
   std::string error;
   return Extension::Create(base::FilePath(),
                            Manifest::INTERNAL,
                            *manifest,
                            Extension::NO_FLAGS,
                            item.id,
                            &error);

[not at google - send to devlin, 2014/08/28 03:17:32]

Would this be a better place to manipulate permissions?

[gpdavis, 2014/08/28 17:41:48]

I put it below so that we did it just before creating the permissions to pass
on, but it does make more sense to just ensure that any extension created in
here gets its permissions initialized.  Done.

 }
 
 bool IsAppPredicate(scoped_refptr<const Extension> extension) {
   return extension->is_app();
 }
 
 struct MatchIdFunctor {
   explicit MatchIdFunctor(const std::string& id) : id(id) {}
   bool operator()(scoped_refptr<const Extension> extension) {
     return extension->id() == id;
@@ skipping 182 matching lines @@
 }
 
 void BundleInstaller::ShowPrompt() {
   // Abort if we couldn't create any Extensions out of the manifests.
   if (dummy_extensions_.empty()) {
     ReportCanceled(false);
     return;
   }
 
   scoped_refptr<PermissionSet> permissions;
+  PermissionsUpdater updater(profile_);
   for (size_t i = 0; i < dummy_extensions_.size(); ++i) {
+    // Initialize permissions so that withheld permissions don't end up in the
+    // install prompt.
+    updater.InitializePermissions(dummy_extensions_[i]);
     permissions = PermissionSet::CreateUnion(
         permissions.get(),
         dummy_extensions_[i]->permissions_data()->active_permissions());
   }
 
   if (g_auto_approve_for_test == PROCEED) {
     InstallUIProceed();
   } else if (g_auto_approve_for_test == ABORT) {
     InstallUIAbort(true);
   } else {
@@ skipping 76 matching lines @@
 void BundleInstaller::OnBrowserAdded(Browser* browser) {}
 
 void BundleInstaller::OnBrowserRemoved(Browser* browser) {
   if (browser_ == browser)
     browser_ = NULL;
 }
 
 void BundleInstaller::OnBrowserSetLastActive(Browser* browser) {}
 
 }  // namespace extensions