Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8559)

Unified Diff: chrome/browser/extensions/api/file_system/file_system_api.cc

Issue 501263002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/api/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Just in case Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/file_system/file_system_api.cc
diff --git a/chrome/browser/extensions/api/file_system/file_system_api.cc b/chrome/browser/extensions/api/file_system/file_system_api.cc
index 8419930f7caf3f95ce596a884dab6bcd46fec7c7..c6689478383ae2d0994974c867a9798d363d6b15 100644
--- a/chrome/browser/extensions/api/file_system/file_system_api.cc
+++ b/chrome/browser/extensions/api/file_system/file_system_api.cc
@@ -298,7 +298,7 @@ bool FileSystemGetWritableEntryFunction::RunAsync() {
EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &filesystem_name));
EXTENSION_FUNCTION_VALIDATE(args_->GetString(1, &filesystem_path));
- if (!app_file_handler_util::HasFileSystemWritePermission(extension_)) {
+ if (!app_file_handler_util::HasFileSystemWritePermission(extension_.get())) {
error_ = kRequiresFileSystemWriteError;
return false;
}
@@ -687,7 +687,8 @@ void FileSystemChooseEntryFunction::ConfirmDirectoryAccessOnFileThread(
FROM_HERE,
base::Bind(
CreateDirectoryAccessConfirmationDialog,
- app_file_handler_util::HasFileSystemWritePermission(extension_),
+ app_file_handler_util::HasFileSystemWritePermission(
+ extension_.get()),
base::UTF8ToUTF16(extension_->name()),
web_contents,
base::Bind(
@@ -709,7 +710,7 @@ void FileSystemChooseEntryFunction::ConfirmDirectoryAccessOnFileThread(
void FileSystemChooseEntryFunction::OnDirectoryAccessConfirmed(
const std::vector<base::FilePath>& paths) {
- if (app_file_handler_util::HasFileSystemWritePermission(extension_)) {
+ if (app_file_handler_util::HasFileSystemWritePermission(extension_.get())) {
PrepareFilesForWritableApp(paths);
return;
}
@@ -794,11 +795,13 @@ bool FileSystemChooseEntryFunction::RunAsync() {
picker_type = ui::SelectFileDialog::SELECT_OPEN_MULTI_FILE;
if (options->type == file_system::CHOOSE_ENTRY_TYPE_OPENWRITABLEFILE &&
- !app_file_handler_util::HasFileSystemWritePermission(extension_)) {
+ !app_file_handler_util::HasFileSystemWritePermission(
+ extension_.get())) {
error_ = kRequiresFileSystemWriteError;
return false;
} else if (options->type == file_system::CHOOSE_ENTRY_TYPE_SAVEFILE) {
- if (!app_file_handler_util::HasFileSystemWritePermission(extension_)) {
+ if (!app_file_handler_util::HasFileSystemWritePermission(
+ extension_.get())) {
error_ = kRequiresFileSystemWriteError;
return false;
}

Powered by Google App Engine
This is Rietveld 408576698