chrome/browser/extensions/api/extension_action/extension_action_api.cc - Issue 501263002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/api/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/extension_action_api.cc

Issue 501263002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/api/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Just in case Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/content_settings/content_settings_api.cc ('K') | « chrome/browser/extensions/api/extension_action/browser_action_browsertest.cc ('k') | chrome/browser/extensions/api/file_handlers/mime_util_unittest.cc » ('j') | chrome/browser/extensions/api/permissions/permissions_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/extension_action_api.cc

diff --git a/chrome/browser/extensions/api/extension_action/extension_action_api.cc b/chrome/browser/extensions/api/extension_action/extension_action_api.cc

index 1029c311c2b8241c81458aac374ac6ebc05c366e..2fff59533b08fe988c3d83937a6d187d8791866f 100644

--- a/chrome/browser/extensions/api/extension_action/extension_action_api.cc

+++ b/chrome/browser/extensions/api/extension_action/extension_action_api.cc

@@ -782,7 +782,7 @@ bool BrowserActionOpenPopupFunction::RunAsync() {

return false;

}

- if (!model->ShowBrowserActionPopup(extension_)) {

+ if (!model->ShowBrowserActionPopup(extension_.get())) {

error_ = kOpenPopupError;

return false;

}