chrome/browser/extensions/api/declarative/rules_registry_service.cc - Issue 501263002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/api/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/rules_registry_service.cc

Issue 501263002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/api/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Just in case Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/content_settings/content_settings_api.cc ('K') | « chrome/browser/extensions/api/declarative/declarative_api.cc ('k') | chrome/browser/extensions/api/extension_action/browser_action_browsertest.cc » ('j') | chrome/browser/extensions/api/permissions/permissions_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/rules_registry_service.cc

diff --git a/chrome/browser/extensions/api/declarative/rules_registry_service.cc b/chrome/browser/extensions/api/declarative/rules_registry_service.cc

index 5da12ef0caa03827575a414a895d2ec686b14e76..476d125c02f7ca43b884960805fd6e9eb26572bb 100644

--- a/chrome/browser/extensions/api/declarative/rules_registry_service.cc

+++ b/chrome/browser/extensions/api/declarative/rules_registry_service.cc

@@ -188,7 +188,7 @@ void RulesRegistryService::NotifyRegistriesHelper(

for (i = rule_registries_.begin(); i != rule_registries_.end(); ++i) {

scoped_refptr<RulesRegistry> registry = i->second;

if (content::BrowserThread::CurrentlyOn(registry->owner_thread())) {

- (registry->*notification_callback)(extension_id);

+ (registry.get()->*notification_callback)(extension_id);

} else {

content::BrowserThread::PostTask(

registry->owner_thread(),