Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/api/

chrome/browser/extensions/api/content_settings/content_settings_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/content_settings/content_settings_api.h"
 
 #include <set>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 69 matching lines @@
     // always allowed to clear its own settings.
   } else {
     // Incognito profiles can't access regular mode ever, they only exist in
     // split mode.
     if (GetProfile()->IsOffTheRecord()) {
       error_ = keys::kIncognitoContextError;
       return false;
     }
   }
 
-  ContentSettingsStore* store =
+  scoped_refptr<ContentSettingsStore> store =

[dcheng, 2014/08/26 00:50:20]

Note: this variable type was rewritten instead of simply adding .get(), because
generally speaking, there is no way of determining if this is safe or not.

If this is safe, please let me know, and I will change this to call .get()
instead of rewriting the variable type. Also consider changing
content_settings_store() to return a const scoped_refptr<>& instead--this will
help avoid spurious refcount churn for callers that really don't need to retain
a reference. (I can also make this change, but please let me know if I should or
not.)

[Jeffrey Yasskin, 2014/08/26 01:14:16]

The change that introduced the scoped_refptr return changed several other places
to store the result into a scoped_refptr, so I'd guess .get() isn't safe.
Returning by & might work, but +rockot to be sure.

       ContentSettingsService::Get(GetProfile())->content_settings_store();
   store->ClearContentSettingsForExtension(extension_id(), scope);
 
   return true;
 }
 
 bool ContentSettingsContentSettingGetFunction::RunSync() {
   ContentSettingsType content_type;
   EXTENSION_FUNCTION_VALIDATE(RemoveContentType(args_.get(), &content_type));
 
@@ skipping 130 matching lines @@
       return false;
     }
   }
 
   if (scope == kExtensionPrefsScopeIncognitoSessionOnly &&
       !GetProfile()->HasOffTheRecordProfile()) {
     error_ = pref_keys::kIncognitoSessionOnlyErrorMessage;
     return false;
   }
 
-  ContentSettingsStore* store =
+  scoped_refptr<ContentSettingsStore> store =

[dcheng, 2014/08/26 00:50:20]

Note: this variable type was rewritten instead of simply adding .get(), because
generally speaking, there is no way of determining if this is safe or not.

If this is safe, please let me know, and I will change this to call .get()
instead of rewriting the variable type. Also consider changing
content_settings_store() to return a const scoped_refptr<>& instead--this will
help avoid spurious refcount churn for callers that really don't need to retain
a reference. (I can also make this change, but please let me know if I should or
not.)

       ContentSettingsService::Get(GetProfile())->content_settings_store();
   store->SetExtensionContentSetting(extension_id(), primary_pattern,
                                     secondary_pattern, content_type,
                                     resource_identifier, setting, scope);
   return true;
 }
 
 bool ContentSettingsContentSettingGetResourceIdentifiersFunction::RunAsync() {
   ContentSettingsType content_type;
   EXTENSION_FUNCTION_VALIDATE(RemoveContentType(args_.get(), &content_type));
@@ skipping 31 matching lines @@
   SetResult(list);
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE, base::Bind(
           &ContentSettingsContentSettingGetResourceIdentifiersFunction::
           SendResponse,
           this,
           true));
 }
 
 }  // namespace extensions