Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 501125: Revert 34983 - Split more targets from chrome.gyp to add support for building... (Closed)

Created:
11 years ago by slightlyoff
Modified:
9 years, 7 months ago
Reviewers:
gregoryd
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), native-client-reviews_googlegroups.com, jam, ben+cc_chromium.org
Visibility:
Public.

Description

Revert 34983 - Split more targets from chrome.gyp to add support for building Native Client for 64bit Windows. This CL is required for supporting Native Client on 64bit Windows. On Win64 we will use a 64bit executable to load NaCl modules. Since we have only one version of Chrome on Windows, this executable has to be built together with 32bit Chrome binaries. For the targets that are required for both 32bit and 64bit builds, this CL moves the shared parts of the target definitions into targetspecific gypi files (such as base.gypi). New 64bit only targets are added. Since we would like to port as few code as possible at this point, some 64bit targets include less source files or less dependencies than the original 32bit targets. These targets will have nacl_win64 in their name to emphasize that they should be used for NaCl only. Some 64bit targets are identical to the 32bit targets in everything except for the target platform these will have only win64 in their name. TEST=none BUG=28176 Review URL: http://codereview.chromium.org/384068 TBR=gregoryd@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34990

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1273 lines, -1781 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/app/dummy_main_functions.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/renderer_host/render_process_host_dummy.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome.gyp View 8 chunks +1271 lines, -12 lines 0 comments Download
D chrome/chrome_common.gypi View 1 chunk +0 lines, -375 lines 0 comments Download
D chrome/chrome_dll.gypi View 1 chunk +0 lines, -516 lines 0 comments Download
D chrome/chrome_exe.gypi View 1 chunk +0 lines, -543 lines 0 comments Download
D chrome/common/resource_dispatcher_dummy.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/common/socket_stream_dispatcher_dummy.cc View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/common_constants.gypi View 1 chunk +0 lines, -96 lines 0 comments Download
D chrome/nacl.gypi View 1 chunk +0 lines, -101 lines 0 comments Download
M chrome/nacl/sel_main.cc View 3 chunks +0 lines, -9 lines 0 comments Download
D webkit/glue/webkit_glue_dummy.cc View 1 chunk +0 lines, -20 lines 0 comments Download
MM webkit/glue/websocketstreamhandle_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
slightlyoff
11 years ago (2009-12-18 22:08:55 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698