Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 384068: gyp changes - add support for building Native Client for 64-bit Windows... (Closed)

Created:
11 years, 1 month ago by gregoryd
Modified:
9 years, 7 months ago
Reviewers:
bradn
CC:
chromium-reviews_googlegroups.com, kuchhal, brettw+cc_chromium.org, jam
Visibility:
Public.

Description

Split more targets from chrome.gyp to add support for building Native Client for 64-bit Windows. This CL is required for supporting Native Client on 64-bit Windows. On Win64 we will use a 64-bit executable to load NaCl modules. Since we have only one version of Chrome on Windows, this executable has to be built together with 32-bit Chrome binaries. For the targets that are required for both 32-bit and 64-bit builds, this CL moves the shared parts of the target definitions into target-specific gypi files (such as base.gypi). New 64-bit only targets are added. Since we would like to port as few code as possible at this point, some 64-bit targets include less source files or less dependencies than the original 32-bit targets. These targets will have nacl_win64 in their name - to emphasize that they should be used for NaCl only. Some 64-bit targets are identical to the 32-bit targets in everything except for the target platform - these will have only win64 in their name. TEST=none BUG=28176 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35237 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35305

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Patch Set 11 : '' #

Patch Set 12 : '' #

Patch Set 13 : '' #

Patch Set 14 : '' #

Patch Set 15 : '' #

Patch Set 16 : '' #

Patch Set 17 : '' #

Patch Set 18 : '' #

Patch Set 19 : '' #

Patch Set 20 : '' #

Patch Set 21 : '' #

Patch Set 22 : '' #

Patch Set 23 : '' #

Patch Set 24 : '' #

Patch Set 25 : '' #

Patch Set 26 : '' #

Patch Set 27 : '' #

Patch Set 28 : '' #

Patch Set 29 : '' #

Total comments: 6

Patch Set 30 : '' #

Patch Set 31 : '' #

Patch Set 32 : '' #

Patch Set 33 : '' #

Patch Set 34 : '' #

Patch Set 35 : '' #

Patch Set 36 : '' #

Patch Set 37 : '' #

Patch Set 38 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1779 lines, -1275 lines) Patch
A chrome/app/dummy_main_functions.cc View 1 chunk +44 lines, -0 lines 0 comments Download
A chrome/browser/renderer_host/render_process_host_dummy.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 8 chunks +12 lines, -1275 lines 0 comments Download
A chrome/chrome_common.gypi View 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 33 34 1 chunk +377 lines, -0 lines 0 comments Download
A chrome/chrome_dll.gypi View 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +516 lines, -0 lines 0 comments Download
A chrome/chrome_exe.gypi View 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 1 chunk +545 lines, -0 lines 0 comments Download
A chrome/common/resource_dispatcher_dummy.cc View 19 20 21 22 23 24 25 26 27 28 29 30 31 32 1 chunk +35 lines, -0 lines 0 comments Download
A chrome/common/socket_stream_dispatcher_dummy.cc View 1 chunk +18 lines, -0 lines 0 comments Download
A chrome/common_constants.gypi View 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 1 chunk +96 lines, -0 lines 0 comments Download
A chrome/nacl.gypi View 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 1 chunk +101 lines, -0 lines 0 comments Download
M chrome/nacl/sel_main.cc View 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 3 chunks +9 lines, -0 lines 0 comments Download
A webkit/glue/webkit_glue_dummy.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
gregoryd
11 years ago (2009-12-18 18:48:11 UTC) #1
bradn
Sigh.... This certainly isn't pretty, but at least it only affects things like chrome_exe / ...
11 years ago (2009-12-18 18:58:42 UTC) #2
bradn
Ok from offline discussion. LGTM, assuming you fix up the comments. The configuration inheritance changes ...
11 years ago (2009-12-18 19:20:35 UTC) #3
gregoryd
http://codereview.chromium.org/384068/diff/42001/42006 File chrome/chrome_common.gypi (right): http://codereview.chromium.org/384068/diff/42001/42006#newcode136 chrome/chrome_common.gypi:136: # All .cc, .h, and .mm files under chrome/common ...
11 years ago (2009-12-18 19:46:10 UTC) #4
bradn
11 years ago (2009-12-18 19:47:22 UTC) #5
LGTM, good luck :-)

Powered by Google App Engine
This is Rietveld 408576698