Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 501116: wm: Update namespace and header define guards. (Closed)

Created:
11 years ago by Daniel Erat
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-os-reviews_googlegroups.com, Greg Spencer (Chromium)
Visibility:
Public.

Description

wm: Update namespace and header define guards. We use a "window_manager" namespace rather than "chromeos" and use e.g. WINDOW_MANAGER_LAYOUT_MANAGER_H_ in headers.

Patch Set 1 #

Patch Set 2 : move using directive inside of namespace for consistency #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -170 lines) Patch
M src/platform/window_manager/atom_cache.h View 3 chunks +4 lines, -4 lines 1 comment Download
M src/platform/window_manager/atom_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/window_manager/clutter_interface.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/platform/window_manager/clutter_interface.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/window_manager/event_consumer.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/platform/window_manager/hotkey_overlay.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/platform/window_manager/hotkey_overlay.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/platform/window_manager/key_bindings.h View 4 chunks +10 lines, -9 lines 0 comments Download
M src/platform/window_manager/key_bindings.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/platform/window_manager/key_bindings_test.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M src/platform/window_manager/layout_manager.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/platform/window_manager/layout_manager.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M src/platform/window_manager/layout_manager_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/platform/window_manager/main.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/platform/window_manager/metrics_reporter.h View 3 chunks +5 lines, -5 lines 0 comments Download
M src/platform/window_manager/metrics_reporter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/platform/window_manager/mock_chrome.h View 4 chunks +7 lines, -7 lines 0 comments Download
M src/platform/window_manager/mock_chrome.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M src/platform/window_manager/mock_x_connection.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/platform/window_manager/mock_x_connection.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/platform/window_manager/motion_event_coalescer.h View 3 chunks +6 lines, -6 lines 0 comments Download
M src/platform/window_manager/motion_event_coalescer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/platform/window_manager/panel.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/platform/window_manager/panel.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/platform/window_manager/panel_bar.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/platform/window_manager/panel_bar.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/platform/window_manager/panel_bar_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/platform/window_manager/panel_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/platform/window_manager/real_x_connection.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/platform/window_manager/real_x_connection.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/platform/window_manager/shadow.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/platform/window_manager/shadow.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/platform/window_manager/shadow_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/platform/window_manager/stacking_manager.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/platform/window_manager/stacking_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/platform/window_manager/stacking_manager_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/platform/window_manager/test_lib.h View 3 chunks +7 lines, -2 lines 0 comments Download
M src/platform/window_manager/test_lib.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/platform/window_manager/util.h View 3 chunks +5 lines, -5 lines 0 comments Download
M src/platform/window_manager/util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/platform/window_manager/util_test.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/platform/window_manager/window.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/platform/window_manager/window.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/platform/window_manager/window_manager.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/platform/window_manager/window_manager.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M src/platform/window_manager/window_manager_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/platform/window_manager/window_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/platform/window_manager/wm_ipc.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/platform/window_manager/wm_ipc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/window_manager/x_connection.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/platform/window_manager/x_connection.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Daniel Erat
11 years ago (2009-12-18 17:57:50 UTC) #1
sky
11 years ago (2009-12-21 15:44:29 UTC) #2
Change your #endif to match the style guide, and LGTM.

http://codereview.chromium.org/501116/diff/2001/2003
File src/platform/window_manager/atom_cache.h (right):

http://codereview.chromium.org/501116/diff/2001/2003#newcode98
src/platform/window_manager/atom_cache.h:98: #endif
Style guide says this should be:

#endif  // WINDOW_MANAGER_ATOM_CACHE_H_

Powered by Google App Engine
This is Rietveld 408576698