Consolidate AppControllDelegate to ExtensionsDelegate

Consolidate AppControllDelegate to ExtensionsDelegate.
* Prep for athena on chrome.

Another notable change:
* pass app_id to AppActivity. it's known at creation time.

Note: this depends on https://codereview.chromium.org/505273002/

BUG=397167
Committed: https://crrev.com/07f5926458490eab81d5d71b88ef18a9b9948ea6
Cr-Commit-Position: refs/heads/master@{#292264}

[oshima, 2014-08-26 20:15:53]

Patchset #1 (id:1) has been deleted

[oshima, 2014-08-26 20:16:59]

oshima@chromium.org changed reviewers:
+ skuhne@chromium.org

[oshima, 2014-08-27 18:18:36]

On 2014/08/26 20:18:37, oshima wrote:

ping?

[Mr4D (OOO till 08-26), 2014-08-27 20:22:19]

Nice to see this being cleaned up!

A few nits though.

https://codereview.chromium.org/501093003/diff/60001/athena/content/app_activ...
File athena/content/app_activity.cc (right):

https://codereview.chromium.org/501093003/diff/60001/athena/content/app_activ...
athena/content/app_activity.cc:122: overview_mode_image_ = gfx::ImageSkia();
Call RegisterActivity from here (or move the code there).

https://codereview.chromium.org/501093003/diff/60001/athena/content/app_activ...
athena/content/app_activity.cc:147: content::NavigationController::ReloadType
reload_type) {
Since this isn't needed anymore: Remove this function altogether.

https://codereview.chromium.org/501093003/diff/60001/athena/extensions/shell/...
File athena/extensions/shell/extensions_delegate_impl.cc (right):

https://codereview.chromium.org/501093003/diff/60001/athena/extensions/shell/...
athena/extensions/shell/extensions_delegate_impl.cc:38: virtual bool
UnloadApp(const std::string& app_id) OVERRIDE { return false; }
Add a todo here that this should be implemented using the extension system since
returning false will close the app window by window which will guarantee that
the windows will not be re-opened upon reload (and the background page might
remain open as well).

[oshima, 2014-08-27 21:20:19]

https://codereview.chromium.org/501093003/diff/60001/athena/content/app_activ...
File athena/content/app_activity.cc (right):

https://codereview.chromium.org/501093003/diff/60001/athena/content/app_activ...
athena/content/app_activity.cc:122: overview_mode_image_ = gfx::ImageSkia();
On 2014/08/27 20:22:19, Mr4D wrote:
> Call RegisterActivity from here (or move the code there).

Done.

https://codereview.chromium.org/501093003/diff/60001/athena/content/app_activ...
athena/content/app_activity.cc:147: content::NavigationController::ReloadType
reload_type) {
On 2014/08/27 20:22:19, Mr4D wrote:
> Since this isn't needed anymore: Remove this function altogether.

Done.

https://codereview.chromium.org/501093003/diff/60001/athena/extensions/shell/...
File athena/extensions/shell/extensions_delegate_impl.cc (right):

https://codereview.chromium.org/501093003/diff/60001/athena/extensions/shell/...
athena/extensions/shell/extensions_delegate_impl.cc:38: virtual bool
UnloadApp(const std::string& app_id) OVERRIDE { return false; }
On 2014/08/27 20:22:19, Mr4D wrote:
> Add a todo here that this should be implemented using the extension system
since
> returning false will close the app window by window which will guarantee that
> the windows will not be re-opened upon reload (and the background page might
> remain open as well).

There will be chrome version
(athena/extensions/shell/extensions_delegate_impl.cc), where you have to add
impl. I'll add TODO there.

[Mr4D (OOO till 08-26), 2014-08-27 22:07:11]

lgtm.

Please add the TODO before submitting...

https://codereview.chromium.org/501093003/diff/60001/athena/extensions/shell/...
File athena/extensions/shell/extensions_delegate_impl.cc (right):

https://codereview.chromium.org/501093003/diff/60001/athena/extensions/shell/...
athena/extensions/shell/extensions_delegate_impl.cc:38: virtual bool
UnloadApp(const std::string& app_id) OVERRIDE { return false; }
You've forgot the TODO.

[oshima, 2014-08-27 22:19:20]

https://codereview.chromium.org/501093003/diff/60001/athena/extensions/shell/...
File athena/extensions/shell/extensions_delegate_impl.cc (right):

https://codereview.chromium.org/501093003/diff/60001/athena/extensions/shell/...
athena/extensions/shell/extensions_delegate_impl.cc:38: virtual bool
UnloadApp(const std::string& app_id) OVERRIDE { return false; }
On 2014/08/27 22:07:11, Mr4D wrote:
> You've forgot the TODO.

Discussed offline and we both agreed that we don't need TODO here.
(It'll be in athena/extensions/chrome/extensions_delegate_impl.cc)

[oshima, 2014-08-27 22:19:26]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-08-27 22:20:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/501093003/80001

[commit-bot: I haz the power, 2014-08-27 23:21:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 23:21:41]

Failed to commit the patch.

[oshima, 2014-08-27 23:29:58]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-08-27 23:32:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/501093003/80001

[commit-bot: I haz the power, 2014-08-27 23:34:41]

Committed patchset #4 (id:80001) as facb822d3052864ee24d211f302181bb38cc5aa8

[commit-bot: I haz the power, 2014-09-10 02:55:30]

Patchset 4 (id:??) landed as
https://crrev.com/07f5926458490eab81d5d71b88ef18a9b9948ea6
Cr-Commit-Position: refs/heads/master@{#292264}