Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Side by Side Diff: athena/activity/public/activity_factory.h

Issue 501093003: Consolidate AppControllDelegate to ExtensionsDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | athena/athena.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ATHENA_ACTIVITY_PUBLIC_ACTIVITY_FACTORY_H_ 5 #ifndef ATHENA_ACTIVITY_PUBLIC_ACTIVITY_FACTORY_H_
6 #define ATHENA_ACTIVITY_PUBLIC_ACTIVITY_FACTORY_H_ 6 #define ATHENA_ACTIVITY_PUBLIC_ACTIVITY_FACTORY_H_
7 7
8 #include "athena/athena_export.h" 8 #include "athena/athena_export.h"
9 #include "url/gurl.h" 9 #include "url/gurl.h"
10 10
(...skipping 26 matching lines...) Expand all
37 virtual ~ActivityFactory() {} 37 virtual ~ActivityFactory() {}
38 38
39 // Create an activity of a web page. 39 // Create an activity of a web page.
40 virtual Activity* CreateWebActivity(content::BrowserContext* browser_context, 40 virtual Activity* CreateWebActivity(content::BrowserContext* browser_context,
41 const GURL& url) = 0; 41 const GURL& url) = 0;
42 42
43 // Create an activity of an app with |app_window| for app shell environemnt. 43 // Create an activity of an app with |app_window| for app shell environemnt.
44 // The returned activity should own |app_window|. 44 // The returned activity should own |app_window|.
45 // TODO(oshima): Consolidate these two methods to create AppActivity 45 // TODO(oshima): Consolidate these two methods to create AppActivity
46 // once crbug.com/403726 is finished. 46 // once crbug.com/403726 is finished.
47 virtual Activity* CreateAppActivity( 47 virtual Activity* CreateAppActivity(extensions::ShellAppWindow* app_window,
48 extensions::ShellAppWindow* app_window) = 0; 48 const std::string& id) = 0;
49 49
50 // Create an activity of an app with |app_window| for chrome environment. 50 // Create an activity of an app with |app_window| for chrome environment.
51 virtual Activity* CreateAppActivity(apps::AppWindow* app_window) = 0; 51 virtual Activity* CreateAppActivity(apps::AppWindow* app_window) = 0;
52 }; 52 };
53 53
54 } // namespace athena 54 } // namespace athena
55 55
56 #endif // ATHENA_ACTIVITY_PUBLIC_ACTIVITY_FACTORY_H_ 56 #endif // ATHENA_ACTIVITY_PUBLIC_ACTIVITY_FACTORY_H_
OLDNEW
« no previous file with comments | « no previous file | athena/athena.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698