Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Unified Diff: chrome/browser/cocoa/nsmenuitem_additions_unittest.mm

Issue 501073: Native Cocoa bookmark manager, part 1 (Closed)
Patch Set: Style fixes, and copy/paste unit tests Created 10 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/nsmenuitem_additions_unittest.mm
diff --git a/chrome/browser/cocoa/nsmenuitem_additions_unittest.mm b/chrome/browser/cocoa/nsmenuitem_additions_unittest.mm
index 478b40d5d6617b7fa3c191178f6add1cde6e71f4..b70630c0bedaaf0a28ca1463b2e03bc75a7c5929 100644
--- a/chrome/browser/cocoa/nsmenuitem_additions_unittest.mm
+++ b/chrome/browser/cocoa/nsmenuitem_additions_unittest.mm
@@ -296,8 +296,12 @@ NSString* keyCodeToCharacter(NSUInteger keyCode,
unicodeString);
assert(err == noErr);
+ NSString* layoutId = (NSString*)TISGetInputSourceProperty(
+ layout, kTISPropertyInputSourceID);
+ EXPECT_GE(maxStringLength, 1u) << layoutId;
+
CFStringRef temp = CFStringCreateWithCharacters(
- kCFAllocatorDefault, unicodeString, 1);
+ kCFAllocatorDefault, unicodeString, maxStringLength >= 1 ? 1 : 0);
return [(NSString*)temp autorelease];
}

Powered by Google App Engine
This is Rietveld 408576698