Native Cocoa bookmark manager, part 1

chrome/browser/cocoa/nsmenuitem_additions_unittest.mm

 #import "chrome/browser/cocoa/nsmenuitem_additions.h"
 
 #include <iostream>
 #include <Carbon/Carbon.h>
 
 #include "base/scoped_nsobject.h"
 #include "base/sys_string_conversions.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 NSEvent* KeyEvent(const NSUInteger modifierFlags,
@@ skipping 278 matching lines @@
       kUCKeyActionDown,
       modifiers,
       LMGetKbdType(),
       kUCKeyTranslateNoDeadKeysBit,
       &deadKeyState,
       maxStringLength,
       &actualStringLength,
       unicodeString);
   assert(err == noErr);
 
+  NSString* layoutId = (NSString*)TISGetInputSourceProperty(
+      layout, kTISPropertyInputSourceID);
+  EXPECT_GE(maxStringLength, 1u) << layoutId;
+
   CFStringRef temp = CFStringCreateWithCharacters(
-      kCFAllocatorDefault, unicodeString, 1);
+      kCFAllocatorDefault, unicodeString, maxStringLength >= 1 ? 1 : 0);
   return [(NSString*)temp autorelease];
 }
 
 TEST(NSMenuItemAdditionsTest, TestMOnDifferentLayouts) {
   // There's one key -- "m" -- that has the same keycode on most keyboard
   //layouts. This function tests a menu item with cmd-m as key equivalent
   // can be fired on all layouts.
   NSMenuItem* item = MenuItem(@"m", 0x100000);
 
   NSDictionary* filter = [NSDictionary
@@ skipping 21 matching lines @@
       keyCode = 0x28;
 
     EventModifiers modifiers = cmdKey >> 8;
     NSString* chars = keyCodeToCharacter(keyCode, modifiers, ref);
     NSString* charsIgnoringMods = keyCodeToCharacter(keyCode, 0, ref);
     NSEvent* key = KeyEvent(0x100000, chars, charsIgnoringMods, keyCode);
     ExpectKeyFiresItem(key, item, false);
   }
   CFRelease(list);
 }