content/browser/renderer_host/render_view_host_impl.cc - Issue 501033003: Remove implicit conversions from scoped_refptr to T* in content/browser/renderer_host/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 501033003: Remove implicit conversions from scoped_refptr to T* in content/browser/renderer_host/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | content/browser/renderer_host/render_widget_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_impl.cc

diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc

index f91a5d72fbe500452e7c8e7e2893dbe38124b35b..8e99ad014f2575035c3c8f24a0ee919e8526fbc7 100644

--- a/content/browser/renderer_host/render_view_host_impl.cc

+++ b/content/browser/renderer_host/render_view_host_impl.cc

@@ -287,7 +287,7 @@ bool RenderViewHostImpl::CreateRenderView(

params.main_frame_routing_id = main_frame_routing_id_;

params.surface_id = surface_id();

params.session_storage_namespace_id =

- delegate_->GetSessionStorageNamespace(instance_)->id();

+ delegate_->GetSessionStorageNamespace(instance_.get())->id();

params.frame_name = frame_name;

// Ensure the RenderView sets its opener correctly.

params.opener_route_id = opener_route_id;

@@ -1396,7 +1396,7 @@ void RenderViewHostImpl::OnWebkitPreferencesChanged() {

void RenderViewHostImpl::GetAudioOutputControllers(

const GetAudioOutputControllersCallback& callback) const {

- AudioRendererHost* audio_host =

+ scoped_refptr<AudioRendererHost> audio_host =

static_cast<RenderProcessHostImpl*>(GetProcess())->audio_renderer_host();

audio_host->GetOutputControllers(GetRoutingID(), callback);

}