content/browser/renderer_host/render_widget_host_impl.cc - Issue 501033003: Remove implicit conversions from scoped_refptr to T* in content/browser/renderer_host/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 501033003: Remove implicit conversions from scoped_refptr to T* in content/browser/renderer_host/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.cc ('k') | content/browser/renderer_host/render_widget_resize_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_impl.cc

diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc

index ce9d1ecb6827d07ad87e082ca4bbdfa8bf256458..30a5246726e3348b80760e5ff8832fa0506725c1 100644

--- a/content/browser/renderer_host/render_widget_host_impl.cc

+++ b/content/browser/renderer_host/render_widget_host_impl.cc

@@ -2148,7 +2148,7 @@ void RenderWidgetHostImpl::WindowSnapshotAsyncCallback(

int snapshot_id,

gfx::Size snapshot_size,

scoped_refptr<base::RefCountedBytes> png_data) {

- if (!png_data) {

+ if (!png_data.get()) {

std::vector<unsigned char> png_vector;

Send(new ViewMsg_WindowSnapshotCompleted(

routing_id, snapshot_id, gfx::Size(), png_vector));

@@ -2237,7 +2237,7 @@ void RenderWidgetHostImpl::OnSnapshotDataReceived(int snapshot_id,

void RenderWidgetHostImpl::OnSnapshotDataReceivedAsync(

int snapshot_id,

scoped_refptr<base::RefCountedBytes> png_data) {

- if (png_data)

+ if (png_data.get())

OnSnapshotDataReceived(snapshot_id, png_data->front(), png_data->size());

else

OnSnapshotDataReceived(snapshot_id, NULL, 0);