We don't need to pass |creationContext| to v8SetReturnValue family

We don't need to pass |creationContext| to v8SetReturnValue family

Just a clean up. No change in behavior.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160892

[haraken, 2013-10-29 11:53:02]

PTAL

[marja, 2013-10-29 11:56:42]

lgtm *except* that you should probably also clean up the custom bindings in the
same go (e.g., V8IntArrayCustom.h and other similar files have v8SetReturnValue
funcs which should get the same cleanup).

[haraken, 2013-10-29 12:11:00]

On 2013/10/29 11:56:42, marja wrote:
> lgtm *except* that you should probably also clean up the custom bindings in
the
> same go (e.g., V8IntArrayCustom.h and other similar files have
v8SetReturnValue
> funcs which should get the same cleanup).

Thanks for pointing them out, marja. Fixed them.

I was surprised that they are hand-written... they should be auto-generated.

[commit-bot: I haz the power, 2013-10-29 12:11:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/50073004/50001

[commit-bot: I haz the power, 2013-10-29 12:11:42]

Failed to apply patch for Source/bindings/tests/results/V8Float64Array.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/tests/results/V8Float64Array.cpp
  Hunk #1 FAILED at 78.
  Hunk #2 succeeded at 150 (offset -1 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
Source/bindings/tests/results/V8Float64Array.cpp.rej

Patch:       Source/bindings/tests/results/V8Float64Array.cpp
Index: Source/bindings/tests/results/V8Float64Array.cpp
diff --git a/Source/bindings/tests/results/V8Float64Array.cpp
b/Source/bindings/tests/results/V8Float64Array.cpp
index
d9f812479e4704b1414d4a8486d1c8c83bfbe500..158c72ba14d69dc5971fec07ba50858898b97b54
100644
--- a/Source/bindings/tests/results/V8Float64Array.cpp
+++ b/Source/bindings/tests/results/V8Float64Array.cpp
@@ -78,7 +78,7 @@ static void fooMethod(const
v8::FunctionCallbackInfo<v8::Value>& args)
     }
     Float64Array* imp = V8Float64Array::toNative(args.Holder());
     V8TRYCATCH_VOID(Float32Array*, array, args[0]->IsFloat32Array() ?
V8Float32Array::toNative(v8::Handle<v8::Float32Array>::Cast(args[0])) : 0);
-    v8SetReturnValue(args, imp->foo(array), args.Holder());
+    v8SetReturnValue(args, imp->foo(array));
     return;
 }
 
@@ -151,9 +151,7 @@ static v8::Handle<v8::FunctionTemplate>
ConfigureV8Float64ArrayTemplate(v8::Hand
     desc->ReadOnlyPrototype();
 
     v8::Local<v8::Signature> defaultSignature;
-    defaultSignature = V8DOMConfiguration::installDOMClassTemplate(desc,
"Float64Array", V8ArrayBufferView::GetTemplate(isolate, currentWorldType),
V8Float64Array::internalFieldCount,
-        0, 0,
-        V8Float64ArrayMethods, WTF_ARRAY_LENGTH(V8Float64ArrayMethods),
isolate, currentWorldType);
+    defaultSignature = V8DOMConfiguration::installDOMClassTemplate(desc,
"Float64Array", V8ArrayBufferView::GetTemplate(isolate, currentWorldType),
V8Float64Array::internalFieldCount, 0, 0, 0, 0, V8Float64ArrayMethods,
WTF_ARRAY_LENGTH(V8Float64ArrayMethods), isolate, currentWorldType);
     UNUSED_PARAM(defaultSignature);
     desc->SetCallHandler(V8Float64Array::constructorCallback);
     desc->SetLength(1);

[marja, 2013-10-29 12:12:15]

On 2013/10/29 12:11:00, haraken wrote:
> On 2013/10/29 11:56:42, marja wrote:
> > lgtm *except* that you should probably also clean up the custom bindings in
> the
> > same go (e.g., V8IntArrayCustom.h and other similar files have
> v8SetReturnValue
> > funcs which should get the same cleanup).
> 
> Thanks for pointing them out, marja. Fixed them.
> 
> I was surprised that they are hand-written... they should be auto-generated.

Yes! They are painful. But there are some complications wrt auto-generating
them. Not sure if we should just try harder. dslomov is the person to talk to.

[commit-bot: I haz the power, 2013-10-29 12:21:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/50073004/100001

[commit-bot: I haz the power, 2013-10-29 12:39:24]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[commit-bot: I haz the power, 2013-10-29 12:44:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/50073004/100001

[commit-bot: I haz the power, 2013-10-29 13:00:19]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[commit-bot: I haz the power, 2013-10-29 15:49:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/50073004/100001

[commit-bot: I haz the power, 2013-10-29 16:11:15]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[commit-bot: I haz the power, 2013-10-30 00:25:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/50073004/240001

[commit-bot: I haz the power, 2013-10-30 02:48:06]

Change committed as 160892

[Nils Barth (inactive), 2013-10-30 03:04:05]

Nice cleanup -- thanks haraken!

Python side is at:
IDL compiler: Remove creationContext from v8SetReturnValue* in Python CG
https://codereview.chromium.org/51993002/