Source/bindings/tests/results/V8Float64Array.cpp - Issue 50073004: We don't need to pass |creationContext| to v8SetReturnValue family

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8Float64Array.cpp

Issue 50073004: We don't need to pass |creationContext| to v8SetReturnValue family (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/tests/results/V8Float64Array.cpp

diff --git a/Source/bindings/tests/results/V8Float64Array.cpp b/Source/bindings/tests/results/V8Float64Array.cpp

index d20265dc41d9f2e6c8235b0f4957be0530e4fa09..0501784351d66e9d73887520ec64464ce3261dd8 100644

--- a/Source/bindings/tests/results/V8Float64Array.cpp

+++ b/Source/bindings/tests/results/V8Float64Array.cpp

@@ -78,7 +78,7 @@ static void fooMethod(const v8::FunctionCallbackInfo<v8::Value>& args)

}

Float64Array* imp = V8Float64Array::toNative(args.Holder());

V8TRYCATCH_VOID(Float32Array*, array, args[0]->IsFloat32Array() ? V8Float32Array::toNative(v8::Handle<v8::Float32Array>::Cast(args[0])) : 0);

- v8SetReturnValue(args, imp->foo(array), args.Holder());

+ v8SetReturnValue(args, imp->foo(array));

}

static void fooMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& args)