Fix crash on Linux when a normal window is created after a hidden window.

Fix crash on Linux when a normal window is created after a hidden window.

It also add some test helper to create tests aimed to test crashes in apps.

BUG=297957
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232033

[benwells, 2013-10-29 21:22:34]

https://codereview.chromium.org/50073003/diff/1/chrome/browser/apps/app_crash...
File chrome/browser/apps/app_crashtest.cc (right):

https://codereview.chromium.org/50073003/diff/1/chrome/browser/apps/app_crash...
chrome/browser/apps/app_crashtest.cc:10: namespace extensions {
no namespace here. we have some clear but not-always-followed rules for
namespaces:
- top level components have their own namespace
- except for chrome which isn't really a namespace
- apart from that namespaces can be used for encapsulation but this is rare.

The extensions namespace is a bit wrong, as it is used for stuff in the top
level extensions component and also for stuff in c/*/extensions. This file is in
neither though..

https://codereview.chromium.org/50073003/diff/1/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/50073003/diff/1/chrome/chrome_tests.gypi#newc...
chrome/chrome_tests.gypi:983: 'browser/apps/app_crashtest.cc',
All our browser tests have file names ending in browsertest.cc. You can call
this one something like app_crash_browsertest.cc.

[benwells, 2013-10-29 21:23:10]

BTW, it's great to see tests coming :)

[mlamouri (slow - plz ping), 2013-10-29 22:30:44]

I applied the reviews comments, I believe it is ready for another review.

[benwells, 2013-10-30 04:34:21]

lgtm

[commit-bot: I haz the power, 2013-10-30 05:22:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mlamouri@chromium.org/50073003/120001

[commit-bot: I haz the power, 2013-10-30 10:25:41]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-10-31 01:03:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mlamouri@chromium.org/50073003/120001

[commit-bot: I haz the power, 2013-10-31 03:08:25]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-10-31 05:57:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mlamouri@chromium.org/50073003/120001

[commit-bot: I haz the power, 2013-10-31 07:33:58]

Change committed as 232033