Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: chrome/browser/apps/app_crash_browsertest.cc

Issue 50073003: Fix crash on Linux when a normal window is created after a hidden window. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: with review comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/gtk/apps/native_app_window_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/app_crash_browsertest.cc
diff --git a/chrome/browser/apps/app_crash_browsertest.cc b/chrome/browser/apps/app_crash_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b3e12d237aa27b8f634e7578226fa6ef53389b1a
--- /dev/null
+++ b/chrome/browser/apps/app_crash_browsertest.cc
@@ -0,0 +1,32 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/apps/app_browsertest_util.h"
+#include "chrome/browser/extensions/extension_test_message_listener.h"
+
+using namespace apps;
+
+// This class of BrowserTests is a helper to create tests related to crashes in
+// Chrome Apps. To be tested, the app will have to be placed as any other test
+// app (see PlatformAppBrowserTest) and will need to send a "Done" message back.
+// When the "Done" message is received, the test succeed. If it is not, it is
+// assumed that Chrome has crashed and the test will anyway fail.
+//
+// The entry in this file should be something like:
+// IN_PROC_BROWSER_TEST_F(AppCrashTest, <TEST_NAME>) {
+// ASSERT_TRUE(RunAppCrashTest("<DIRECTORY_TEST_NAME>"));
+// }
+
+class AppCrashTest : public extensions::PlatformAppBrowserTest {
+public:
+ bool RunAppCrashTest(const char* name) {
+ ExtensionTestMessageListener listener("Done", false);
+ LoadAndLaunchPlatformApp(name);
+ return listener.WaitUntilSatisfied();
+ }
+};
+
+IN_PROC_BROWSER_TEST_F(AppCrashTest, HiddenWindows) {
+ ASSERT_TRUE(RunAppCrashTest("crashtest_hidden_windows"));
+}
« no previous file with comments | « no previous file | chrome/browser/ui/gtk/apps/native_app_window_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698