Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 500543002: Fixing LSan: Moving credential creation to a scoped_ptr for correct removal. (Closed)

Created:
6 years, 4 months ago by Mike West
Modified:
6 years, 4 months ago
Reviewers:
Finnur
CC:
chromium-reviews, darin-cc_chromium.org, gcasto+watchlist_chromium.org, jam, mkwst+watchlist_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fixing LSan: Moving credential creation to a scoped_ptr for correct removal. TBR=finnur@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291404

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M components/password_manager/content/renderer/credential_manager_client_unittest.cc View 5 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mike West
TBRing this to you, Finnur. :)
6 years, 4 months ago (2014-08-22 14:51:28 UTC) #1
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 4 months ago (2014-08-22 14:51:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/500543002/1
6 years, 4 months ago (2014-08-22 14:52:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (1) as 291404
6 years, 4 months ago (2014-08-22 14:53:47 UTC) #4
Finnur
6 years, 4 months ago (2014-08-22 15:12:05 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698