Fixing LSan: Moving credential creation to a scoped_ptr for correct removal.

components/password_manager/content/renderer/credential_manager_client_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/content/common/credential_manager_messages.h"
 #include "components/password_manager/content/renderer/credential_manager_client.h"
 #include "components/password_manager/content/renderer/test_credential_manager_client.h"
 #include "content/public/test/mock_render_thread.h"
 #include "content/test/blink_test_environment.h"
 #include "ipc/ipc_test_sink.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/public/platform/WebCredential.h"
 #include "third_party/WebKit/public/platform/WebCredentialManagerClient.h"
 #include "third_party/WebKit/public/platform/WebCredentialManagerError.h"
 
 namespace password_manager {
 
 namespace {
 
 class CredentialManagerClientTest : public testing::Test {
  public:
   CredentialManagerClientTest()
       : callback_errored_(false),
-        callback_succeeded_(false) {}
+        callback_succeeded_(false) {
+    blink::WebString string = blink::WebString::fromUTF8("");
+    GURL url("https://example.com/image");
+    credential_.reset(new blink::WebCredential(string, string, url));
+  }
   virtual ~CredentialManagerClientTest() {}
 
   static void SetUpTestCase() { content::SetUpBlinkTestEnvironment(); }
 
   static void TearDownTestCase() { content::TearDownBlinkTestEnvironment(); }
 
   IPC::TestSink& sink() { return render_thread_.sink(); }
 
+  blink::WebCredential* credential() { return credential_.get(); }
+
   // The browser's response to any of the messages the client sends must contain
   // a request ID so that the client knows which request is being serviced. This
   // method grabs the ID from an outgoing |message_id| message, and sets the
   // |request_id| param to its value. If no request ID can be found, the method
   // returns false, and the |request_id| is set to -1.
   //
   // Clears any pending messages upon return.
   bool ExtractRequestId(uint32 message_id, int& request_id) {
     request_id = -1;
     const IPC::Message* message = sink().GetFirstMessageMatching(message_id);
@@ skipping 45 matching lines @@
   content::MockRenderThread render_thread_;
   TestCredentialManagerClient client_;
 
   // True if a message's callback's 'onSuccess'/'onError' methods were called,
   // false otherwise. We put these on the test object rather than on the
   // Test*Callbacks objects because ownership of those objects passes into the
   // client, which destroys the callbacks after calling them to resolve the
   // pending Blink-side Promise.
   bool callback_errored_;
   bool callback_succeeded_;
+
+  scoped_ptr<blink::WebCredential> credential_;
 };
 
 class TestNotificationCallbacks
     : public blink::WebCredentialManagerClient::NotificationCallbacks {
  public:
   explicit TestNotificationCallbacks(CredentialManagerClientTest* test)
       : test_(test) {
   }
 
   virtual ~TestNotificationCallbacks() {}
@@ skipping 29 matching lines @@
   CredentialManagerClientTest* test_;
 };
 
 }  // namespace
 
 TEST_F(CredentialManagerClientTest, SendNotifyFailedSignIn) {
   int request_id;
   EXPECT_FALSE(ExtractRequestId(CredentialManagerHostMsg_NotifyFailedSignIn::ID,
                                 request_id));
 
-  blink::WebCredential credential(
-      "id", "user", GURL("https://example.com/img.png"));
   scoped_ptr<TestNotificationCallbacks> callbacks(
       new TestNotificationCallbacks(this));
-  client_.dispatchFailedSignIn(credential, callbacks.release());
+  client_.dispatchFailedSignIn(*credential(), callbacks.release());
 
   EXPECT_TRUE(ExtractRequestId(CredentialManagerHostMsg_NotifyFailedSignIn::ID,
                                request_id));
 
   client_.OnAcknowledgeFailedSignIn(request_id);
   EXPECT_TRUE(callback_succeeded());
   EXPECT_FALSE(callback_errored());
 }
 
 TEST_F(CredentialManagerClientTest, SendNotifySignedIn) {
   int request_id;
   EXPECT_FALSE(ExtractRequestId(CredentialManagerHostMsg_NotifySignedIn::ID,
                                 request_id));
 
-  blink::WebCredential credential(
-      "id", "user", GURL("https://example.com/img.png"));
   scoped_ptr<TestNotificationCallbacks> callbacks(
       new TestNotificationCallbacks(this));
-  client_.dispatchSignedIn(credential, callbacks.release());
+  client_.dispatchSignedIn(*credential(), callbacks.release());
 
   EXPECT_TRUE(ExtractRequestId(CredentialManagerHostMsg_NotifySignedIn::ID,
                                request_id));
 
   client_.OnAcknowledgeSignedIn(request_id);
   EXPECT_TRUE(callback_succeeded());
   EXPECT_FALSE(callback_errored());
 }
 
 TEST_F(CredentialManagerClientTest, SendNotifySignedOut) {
@@ skipping 25 matching lines @@
   EXPECT_TRUE(ExtractRequestId(CredentialManagerHostMsg_RequestCredential::ID,
                                request_id));
 
   CredentialInfo info;
   client_.OnSendCredential(request_id, info);
   EXPECT_TRUE(callback_succeeded());
   EXPECT_FALSE(callback_errored());
 }
 
 }  // namespace password_manager