components/rappor/log_uploader_unittest.cc - Issue 500383003: Remove implicit conversions from scoped_refptr to T* in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/rappor/log_uploader_unittest.cc

Issue 500383003: Remove implicit conversions from scoped_refptr to T* in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/precache/core/precache_fetcher.cc ('k') | components/search_engines/template_url_service.cc » ('j') | components/webdata/common/web_database_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/rappor/log_uploader_unittest.cc

diff --git a/components/rappor/log_uploader_unittest.cc b/components/rappor/log_uploader_unittest.cc

index 8c175b4e4a66fa3f89dd6f14af413c515a0908e2..ac37ed999af56f13241f0e6c615af262c4e4b7a4 100644

--- a/components/rappor/log_uploader_unittest.cc

+++ b/components/rappor/log_uploader_unittest.cc

@@ -70,7 +70,7 @@ class LogUploaderTest : public testing::Test {

};

TEST_F(LogUploaderTest, Success) {

- TestLogUploader uploader(request_context_);

+ TestLogUploader uploader(request_context_.get());

factory_.SetFakeResponse(GURL(kTestServerURL),

std::string(),

@@ -84,7 +84,7 @@ TEST_F(LogUploaderTest, Success) {

}

TEST_F(LogUploaderTest, Rejection) {

- TestLogUploader uploader(request_context_);

+ TestLogUploader uploader(request_context_.get());

factory_.SetFakeResponse(GURL(kTestServerURL),

std::string(),

@@ -98,7 +98,7 @@ TEST_F(LogUploaderTest, Rejection) {

}

TEST_F(LogUploaderTest, Failure) {

- TestLogUploader uploader(request_context_);

+ TestLogUploader uploader(request_context_.get());

factory_.SetFakeResponse(GURL(kTestServerURL),

std::string(),