Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: components/precache/core/precache_fetcher.cc

Issue 500383003: Remove implicit conversions from scoped_refptr to T* in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/precache/core/precache_fetcher.cc
diff --git a/components/precache/core/precache_fetcher.cc b/components/precache/core/precache_fetcher.cc
index 78ae7ac785119e15d34fea3d4060097bd625d2ab..81053ce5dcf6c23acae6781a0e1fa00154debfe9 100644
--- a/components/precache/core/precache_fetcher.cc
+++ b/components/precache/core/precache_fetcher.cc
@@ -136,7 +136,7 @@ PrecacheFetcher::PrecacheFetcher(
: starting_urls_(starting_urls),
request_context_(request_context),
precache_delegate_(precache_delegate) {
- DCHECK(request_context_); // Request context must be non-NULL.
+ DCHECK(request_context_.get()); // Request context must be non-NULL.
DCHECK(precache_delegate_); // Precache delegate must be non-NULL.
DCHECK_NE(GURL(), GetConfigURL())
@@ -155,7 +155,8 @@ void PrecacheFetcher::Start() {
DCHECK(config_url.is_valid());
// Fetch the precache configuration settings from the server.
- fetcher_.reset(new Fetcher(request_context_, config_url,
+ fetcher_.reset(new Fetcher(request_context_.get(),
+ config_url,
base::Bind(&PrecacheFetcher::OnConfigFetchComplete,
base::Unretained(this))));
}
@@ -164,7 +165,8 @@ void PrecacheFetcher::StartNextFetch() {
if (!resource_urls_to_fetch_.empty()) {
// Fetch the next resource URL.
fetcher_.reset(
- new Fetcher(request_context_, resource_urls_to_fetch_.front(),
+ new Fetcher(request_context_.get(),
+ resource_urls_to_fetch_.front(),
base::Bind(&PrecacheFetcher::OnResourceFetchComplete,
base::Unretained(this))));
@@ -175,7 +177,8 @@ void PrecacheFetcher::StartNextFetch() {
if (!manifest_urls_to_fetch_.empty()) {
// Fetch the next manifest URL.
fetcher_.reset(
- new Fetcher(request_context_, manifest_urls_to_fetch_.front(),
+ new Fetcher(request_context_.get(),
+ manifest_urls_to_fetch_.front(),
base::Bind(&PrecacheFetcher::OnManifestFetchComplete,
base::Unretained(this))));

Powered by Google App Engine
This is Rietveld 408576698