Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 500373005: Remove SkQuadTree. (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove SkQuadTree. We're not testing it to the same degree we do RTree and TileGrid. Any changes we'll make to BBH APIs become 33% easier without it. If find we want it again, we can always resurrect it. BUG=skia:1021, skia:2834 TBR=reed Committed: https://skia.googlesource.com/skia/+/2a65a238b0e688356aee09d08f3f8a317359b4d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -661 lines) Patch
D bench/QuadTreeBench.cpp View 1 chunk +0 lines, -216 lines 0 comments Download
M dm/DMCpuGMTask.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M dm/DMQuiltTask.h View 1 chunk +0 lines, -1 line 0 comments Download
M dm/DMQuiltTask.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M gm/gmmain.cpp View 4 chunks +0 lines, -21 lines 0 comments Download
M gyp/bench.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkBBHFactory.h View 1 chunk +0 lines, -8 lines 0 comments Download
M samplecode/SamplePictFile.cpp View 3 chunks +0 lines, -7 lines 0 comments Download
M src/core/SkBBHFactory.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
D src/core/SkQuadTree.h View 1 chunk +0 lines, -113 lines 0 comments Download
D src/core/SkQuadTree.cpp View 1 chunk +0 lines, -219 lines 0 comments Download
M tests/BBoxHierarchyTest.cpp View 2 chunks +0 lines, -17 lines 0 comments Download
M tests/PictureTest.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M tools/PictureRenderer.h View 7 chunks +9 lines, -14 lines 0 comments Download
M tools/PictureRenderer.cpp View 4 chunks +6 lines, -8 lines 0 comments Download
M tools/PictureRenderingFlags.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M tools/bbh_shootout.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M tools/bench_record.cpp View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
mtklein
mtklein@google.com changed reviewers: + mtklein@google.com, robertphillips@google.com
6 years, 3 months ago (2014-08-26 20:52:44 UTC) #1
mtklein
6 years, 3 months ago (2014-08-26 20:52:44 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 3 months ago (2014-08-26 20:55:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/500373005/1
6 years, 3 months ago (2014-08-26 20:56:02 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-08-26 20:56:03 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 20:56:14 UTC) #6
commit-bot: I haz the power
Presubmit check for 500373005-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 3 months ago (2014-08-26 20:56:15 UTC) #7
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 3 months ago (2014-08-26 20:56:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/500373005/1
6 years, 3 months ago (2014-08-26 20:58:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (1) as 2a65a238b0e688356aee09d08f3f8a317359b4d2
6 years, 3 months ago (2014-08-26 21:07:09 UTC) #10
mtklein
On 2014/08/26 21:07:09, I haz the power (commit-bot) wrote: > Committed patchset #1 (1) as ...
6 years, 3 months ago (2014-08-26 21:11:26 UTC) #11
robertphillips
6 years, 3 months ago (2014-08-26 21:33:02 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698