Remove implicit conversions from scoped_refptr to T* in cc/trees/

cc/trees/layer_tree_host_impl.cc

Index: cc/trees/layer_tree_host_impl.cc
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc
index afba687b2d8d3bcdc42ae39e27fdb42e95d1e043..9baa32e33d73a2f3bd1080d12da2e48b5c9aaf31 100644
--- a/cc/trees/layer_tree_host_impl.cc
+++ b/cc/trees/layer_tree_host_impl.cc
@@ -1946,7 +1946,8 @@ void LayerTreeHostImpl::CreateAndSetTileManager() {
   DCHECK(resource_provider_);
   DCHECK(proxy_->ImplThreadTaskRunner());
 
-  ContextProvider* context_provider = output_surface_->context_provider();
+  scoped_refptr<ContextProvider> context_provider =

[danakj, 2014/08/25 20:25:01]

I don't see anything this is passed to needing a scoped_refptr. Can you not just
use .get() here?

[dcheng, 2014/08/25 20:56:58]

This is the tool's logic kicking in--context_provider() returns a
scoped_refptr<T>. Something like Foo* f = CreateFoo() would be unsafe. But since
this is just a simple accessor, it should be safe--I'll add a little logic to
try to skip rewriting the receiver type in these cases. I've also manually
reverted this to get().

+      output_surface_->context_provider();
   transfer_buffer_memory_limit_ =
       GetMaxTransferBufferUsageBytes(context_provider);

[danakj, 2014/08/25 20:25:01]

If not you need .get() here and in most of these places below in this method.

[dcheng, 2014/08/25 20:56:58]

Yeah, that's the problem with this tool--it's single pass. I should have run it
twice at least.