Remove implicit conversions from scoped_refptr to T* in cc/trees/

cc/trees/layer_tree_host_impl.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_host_impl.h"
 
 #include <algorithm>
 #include <limits>
 
 #include "base/basictypes.h"
@@ skipping 1928 matching lines @@
   client_->UpdateRendererCapabilitiesOnImplThread();
 }
 
 void LayerTreeHostImpl::CreateAndSetTileManager() {
   DCHECK(!tile_manager_);
   DCHECK(settings_.impl_side_painting);
   DCHECK(output_surface_);
   DCHECK(resource_provider_);
   DCHECK(proxy_->ImplThreadTaskRunner());
 
-  ContextProvider* context_provider = output_surface_->context_provider();
+  scoped_refptr<ContextProvider> context_provider =

[danakj, 2014/08/25 20:25:01]

I don't see anything this is passed to needing a scoped_refptr. Can you not just
use .get() here?

[dcheng, 2014/08/25 20:56:58]

This is the tool's logic kicking in--context_provider() returns a
scoped_refptr<T>. Something like Foo* f = CreateFoo() would be unsafe. But since
this is just a simple accessor, it should be safe--I'll add a little logic to
try to skip rewriting the receiver type in these cases. I've also manually
reverted this to get().

+      output_surface_->context_provider();
   transfer_buffer_memory_limit_ =
       GetMaxTransferBufferUsageBytes(context_provider);

[danakj, 2014/08/25 20:25:01]

If not you need .get() here and in most of these places below in this method.

[dcheng, 2014/08/25 20:56:58]

Yeah, that's the problem with this tool--it's single pass. I should have run it
twice at least.

 
   if (use_gpu_rasterization_ && context_provider) {
     resource_pool_ =
         ResourcePool::Create(resource_provider_.get(),
                              GL_TEXTURE_2D,
                              resource_provider_->best_texture_format());
 
     raster_worker_pool_ =
         GpuRasterWorkerPool::Create(proxy_->ImplThreadTaskRunner(),
                                     context_provider,
@@ skipping 1386 matching lines @@
 }
 
 void LayerTreeHostImpl::UnregisterPictureLayerImpl(PictureLayerImpl* layer) {
   std::vector<PictureLayerImpl*>::iterator it =
       std::find(picture_layers_.begin(), picture_layers_.end(), layer);
   DCHECK(it != picture_layers_.end());
   picture_layers_.erase(it);
 }
 
 }  // namespace cc