Added code to dismiss url suggestion popup on back key press.

Added code to dismiss url suggestion popup on back key press.

URL suggestion popup was not dismissing when page was navigating
in back direction. Added code to handle this.

BUG=407070
Committed: https://crrev.com/842da1ea77d304d3790f0df0cc2286cb5320e791
Cr-Commit-Position: refs/heads/master@{#291890}

[ankit, 2014-08-25 11:52:13]

PTAL

[Bernhard Bauer, 2014-08-26 07:46:10]

https://codereview.chromium.org/500043002/diff/1/chrome/android/shell/java/sr...
File
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
(right):

https://codereview.chromium.org/500043002/diff/1/chrome/android/shell/java/sr...
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java:146:
if (event != null && keyCode == KeyEvent.KEYCODE_BACK) {
Is this actually called with a null event?

[ankit, 2014-08-26 08:16:33]

https://codereview.chromium.org/500043002/diff/1/chrome/android/shell/java/sr...
File
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
(right):

https://codereview.chromium.org/500043002/diff/1/chrome/android/shell/java/sr...
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java:146:
if (event != null && keyCode == KeyEvent.KEYCODE_BACK) {
On 2014/08/26 07:46:10, Bernhard Bauer wrote:
> Is this actually called with a null event?

I did not encounter any scenario when it was getting 
called with null event. Just to be on safer side I added
it. Please suggest if it is not required.

[Bernhard Bauer, 2014-08-26 08:20:43]

https://codereview.chromium.org/500043002/diff/1/chrome/android/shell/java/sr...
File
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
(right):

https://codereview.chromium.org/500043002/diff/1/chrome/android/shell/java/sr...
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java:146:
if (event != null && keyCode == KeyEvent.KEYCODE_BACK) {
On 2014/08/26 08:16:32, ankit wrote:
> On 2014/08/26 07:46:10, Bernhard Bauer wrote:
> > Is this actually called with a null event?
> 
> I did not encounter any scenario when it was getting 
> called with null event. Just to be on safer side I added
> it. Please suggest if it is not required.

I would rather not add it. Your assumption (and mine) is that this is never
called with null, but if it were, you wouldn't find out, because you're silently
handling that case. If we remove the null check, the assumption is made clear,
and if it's violated, we will get crash reports.

[ankit, 2014-08-26 08:32:31]

On 2014/08/26 08:20:43, Bernhard Bauer wrote:
>
https://codereview.chromium.org/500043002/diff/1/chrome/android/shell/java/sr...
> File
>
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
> (right):
> 
>
https://codereview.chromium.org/500043002/diff/1/chrome/android/shell/java/sr...
>
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java:146:
> if (event != null && keyCode == KeyEvent.KEYCODE_BACK) {
> On 2014/08/26 08:16:32, ankit wrote:
> > On 2014/08/26 07:46:10, Bernhard Bauer wrote:
> > > Is this actually called with a null event?
> > 
> > I did not encounter any scenario when it was getting 
> > called with null event. Just to be on safer side I added
> > it. Please suggest if it is not required.
> 
> I would rather not add it. Your assumption (and mine) is that this is never
> called with null, but if it were, you wouldn't find out, because you're
silently
> handling that case. If we remove the null check, the assumption is made clear,
> and if it's violated, we will get crash reports.

PTAL new patch.
I have removed null check.

[Bernhard Bauer, 2014-08-26 10:00:32]

lgtm

[ankit, 2014-08-26 10:10:03]

On 2014/08/26 10:00:32, Bernhard Bauer wrote:
> lgtm

Thanks.

[ankit, 2014-08-26 10:10:09]

The CQ bit was checked by ankit2.kumar@samsung.com

[commit-bot: I haz the power, 2014-08-26 10:10:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ankit2.kumar@samsung.com/500043002/20001

[commit-bot: I haz the power, 2014-08-26 12:11:22]

Committed patchset #2 (20001) as b85f1f6bf39b53c26223a14dd4ed568036a09b41

[commit-bot: I haz the power, 2014-09-10 02:42:20]

Patchset 2 (id:??) landed as
https://crrev.com/842da1ea77d304d3790f0df0cc2286cb5320e791
Cr-Commit-Position: refs/heads/master@{#291890}