Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 499743002: Delays creating a snapshot file until after the snapshot is created. (Closed)

Created:
6 years, 4 months ago by zra
Modified:
6 years, 3 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, nweiz
Visibility:
Public.

Description

Delays creating a snapshot file until after the snapshot is created. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=39998

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Added test #

Patch Set 4 : moved tests to standalone/io #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -7 lines) Patch
M runtime/bin/main.cc View 1 2 3 4 chunks +11 lines, -7 lines 0 comments Download
A tests/standalone/io/snapshot_fail_script.dart View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
A tests/standalone/io/snapshot_fail_test.dart View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zra
6 years, 4 months ago (2014-08-22 22:23:43 UTC) #1
zra
PTAL
6 years, 3 months ago (2014-09-02 18:41:44 UTC) #2
Ivan Posva
LGTM -ip
6 years, 3 months ago (2014-09-08 20:30:27 UTC) #3
zra
6 years, 3 months ago (2014-09-08 20:52:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as r39998 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698