Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 499543002: Removing duplicate 'using namespace blink;' in platform and web (Closed)

Created:
6 years, 4 months ago by shreeramk
Modified:
6 years, 3 months ago
CC:
blink-reviews, urvang (Google), jzern, skal, vikasa
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Removing duplicate 'using namespace blink' in platform and web Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180942

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/image-decoders/jpeg/JPEGImageDecoderTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/image-decoders/webp/WEBPImageDecoderTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/PopupContainerTest.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/PopupMenuTest.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/CustomEventTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/KeyboardTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/LinkHighlightTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/tests/PageSerializerTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/PaintAggregatorTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/PinchViewportTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/ProgrammaticScrollTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/RenderGeometryMapTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/ScrollingCoordinatorChromiumTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/TextFinderTest.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/WebImageTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/WebInputEventConversionTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/WebScopedWindowFocusAllowedIndicatorTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/WebSearchableFormDataTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/WebUserGestureTokenTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
shreeramk
Please review. Thanks!
6 years, 4 months ago (2014-08-22 07:04:03 UTC) #1
urvang (Google)
LGTM for WebPImageDecoderTest
6 years, 4 months ago (2014-08-22 07:08:08 UTC) #2
shreeramk
@abarth: could you please review this. Thanks :)
6 years, 3 months ago (2014-08-26 12:46:48 UTC) #3
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 3 months ago (2014-08-26 22:03:14 UTC) #4
tkent
lgtm https://codereview.chromium.org/499543002/diff/1/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp File Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp (right): https://codereview.chromium.org/499543002/diff/1/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp#newcode46 Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp:46: using namespace blink; nit: this |using| should be ...
6 years, 3 months ago (2014-08-26 22:03:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shreeram.k@samsung.com/499543002/1
6 years, 3 months ago (2014-08-26 22:04:13 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 22:04:24 UTC) #7
commit-bot: I haz the power
Failed to apply patch for Source/web/tests/PopupContainerTest.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
6 years, 3 months ago (2014-08-26 22:04:25 UTC) #8
shreeramk
The CQ bit was checked by shreeram.k@samsung.com
6 years, 3 months ago (2014-08-27 06:02:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shreeram.k@samsung.com/499543002/20001
6 years, 3 months ago (2014-08-27 06:03:22 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 3 months ago (2014-08-27 07:11:42 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-08-27 07:45:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180942

Powered by Google App Engine
This is Rietveld 408576698