Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 499453002: Move actions after browser Start in cros_browser_backend.Start to DidStart. (Closed)

Created:
6 years, 4 months ago by nednguyen
Modified:
6 years, 4 months ago
Reviewers:
achuithb, jennyz
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move actions after browser Start in cros_browser_backend.Start to DidStart. BUG=406010 NOTRY=true NOTREECHECKS=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291310

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
nednguyen
6 years, 4 months ago (2014-08-21 20:25:38 UTC) #1
nednguyen
On 2014/08/21 20:25:38, nednguyen wrote: Please wait for the bot X86 (chromium) to confirm whether ...
6 years, 4 months ago (2014-08-21 20:26:21 UTC) #2
nednguyen
On 2014/08/21 20:25:38, nednguyen wrote: Please wait for the bot X86 (chromium) to confirm whether ...
6 years, 4 months ago (2014-08-21 20:26:22 UTC) #3
achuithb
lgtm if you're able to run this against the bots.
6 years, 4 months ago (2014-08-21 22:48:43 UTC) #4
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 4 months ago (2014-08-21 23:07:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/499453002/1
6 years, 4 months ago (2014-08-21 23:09:40 UTC) #6
nednguyen
The CQ bit was unchecked by nednguyen@google.com
6 years, 4 months ago (2014-08-22 00:28:26 UTC) #7
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 4 months ago (2014-08-22 00:28:26 UTC) #8
nednguyen
The CQ bit was unchecked by nednguyen@google.com
6 years, 4 months ago (2014-08-22 00:28:37 UTC) #9
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 4 months ago (2014-08-22 00:28:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/499453002/1
6 years, 4 months ago (2014-08-22 00:31:46 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (1) as 291310
6 years, 4 months ago (2014-08-22 01:48:58 UTC) #12
nednguyen
6 years, 4 months ago (2014-08-22 16:23:40 UTC) #13
Message was sent while issue was closed. 
A revert of this CL (patchset #1) has been created in
https://codereview.chromium.org/502503002/ by nednguyen@google.com.

The reason for reverting is: The original patch of this
(https://codereview.chromium.org/449753002/) broke chromeos bot in
https://code.google.com/p/chromium/issues/detail?id=406010.

Powered by Google App Engine
This is Rietveld 408576698