tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py - Issue 499453002: Move actions after browser Start in cros_browser_backend.Start to DidStart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

Issue 499453002: Move actions after browser Start in cros_browser_backend.Start to DidStart. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

index bb431cea554e3c2631fd6a830583e61e63751582..1d2347e022ea0dffe80cf769a26a7c3d5a86e189 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

@@ -136,7 +136,10 @@ class CrOSBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

# Wait for oobe.

self._WaitForBrowserToComeUp(wait_for_extensions=False)

util.WaitFor(lambda: self.oobe_exists, 10)

+ logging.info('Browser is up!')

+ def DidStart(self):

+ super(CrOSBrowserBackend, self).DidStart()

if self.browser_options.auto_login:

try:

if self._is_guest:

@@ -154,7 +157,6 @@ class CrOSBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

self._cri.TakeScreenShot('login-screen')

raise exceptions.LoginException('Timed out going through login screen')

- logging.info('Browser is up!')

def Close(self):

super(CrOSBrowserBackend, self).Close()

« no previous file with comments | « no previous file | no next file » | no next file with comments »