Issue 49933002: [OTS] build failure on QNX

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 49933002: [OTS] build failure on QNX (Closed)

Created:
7 years, 1 month ago by efidler1

Modified:
7 years, 1 month ago

Reviewers:
Kunihiko Sakamoto

CC:
chromium-reviews

Base URL:
ssh://git.rim.net/users/efidler/ots.git@blackberry_5

Visibility:
Public.

More Reviews

Description

[OTS] build failure on QNX on QNX, "#include <cstring>" doesn't put memcpy in the global namespace BUG=312446

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	include/ots-memory-stream.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/cmap.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kunihiko Sakamoto

7 years, 1 month ago (2013-11-01 05:50:59 UTC) #3

On 2013/11/01 05:46:06, ksakamoto wrote:
> lgtm
> 
> Thank you for the patch. I will land this.

Landed in https://code.google.com/p/ots/source/detail?r=105

Expand Messages | Collapse Messages