Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 499243002: Send less data in the DataSender test that timed out under valgrind. (Closed)

Created:
6 years, 4 months ago by Sam McNally
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, bruening+watch_chromium.org, glider+watch_chromium.org, timurrrr+watch_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Send less data in the DataSender test that timed out under valgrind. BUG=405531 Committed: https://crrev.com/f00a56183896583b21676da1de378cc15aaa42a0 Cr-Commit-Position: refs/heads/master@{#291872}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : change all the large send tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M extensions/renderer/api/serial/data_sender_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/test/data/data_sender_unittest.js View 1 5 chunks +6 lines, -6 lines 0 comments Download
M tools/valgrind/gtest_exclude/extensions_unittests.gtest-memcheck.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Sam McNally
timurrrr@chromium.org: Please review changes in tools/valgrind benwells@chromium.org: Please review changes in extensions
6 years, 4 months ago (2014-08-25 08:08:02 UTC) #1
Alexander Potapenko
tools/valgrind LGTM
6 years, 4 months ago (2014-08-25 09:02:27 UTC) #2
benwells
https://codereview.chromium.org/499243002/diff/20001/extensions/test/data/data_sender_unittest.js File extensions/test/data/data_sender_unittest.js (right): https://codereview.chromium.org/499243002/diff/20001/extensions/test/data/data_sender_unittest.js#newcode70 extensions/test/data/data_sender_unittest.js:70: sender.send(generateData(BUFFER_SIZE * 100, 'b')).catch(test.callbackPass( Should this one change too?
6 years, 3 months ago (2014-08-26 03:49:01 UTC) #3
Sam McNally
https://codereview.chromium.org/499243002/diff/20001/extensions/test/data/data_sender_unittest.js File extensions/test/data/data_sender_unittest.js (right): https://codereview.chromium.org/499243002/diff/20001/extensions/test/data/data_sender_unittest.js#newcode70 extensions/test/data/data_sender_unittest.js:70: sender.send(generateData(BUFFER_SIZE * 100, 'b')).catch(test.callbackPass( On 2014/08/26 03:49:01, benwells wrote: ...
6 years, 3 months ago (2014-08-26 04:03:24 UTC) #4
benwells
lgtm
6 years, 3 months ago (2014-08-26 05:34:24 UTC) #5
Sam McNally
The CQ bit was checked by sammc@chromium.org
6 years, 3 months ago (2014-08-26 06:38:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/499243002/40001
6 years, 3 months ago (2014-08-26 06:39:05 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (40001) as 9d336880203a23db446a6dade6609311a3abdf32
6 years, 3 months ago (2014-08-26 09:01:25 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:41:36 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f00a56183896583b21676da1de378cc15aaa42a0
Cr-Commit-Position: refs/heads/master@{#291872}

Powered by Google App Engine
This is Rietveld 408576698