extensions/test/data/data_sender_unittest.js - Issue 499243002: Send less data in the DataSender test that timed out under valgrind.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/test/data/data_sender_unittest.js

Issue 499243002: Send less data in the DataSender test that timed out under valgrind. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change all the large send tests Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/renderer/api/serial/data_sender_unittest.cc ('k') | tools/valgrind/gtest_exclude/extensions_unittests.gtest-memcheck.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/test/data/data_sender_unittest.js

diff --git a/extensions/test/data/data_sender_unittest.js b/extensions/test/data/data_sender_unittest.js

index 18ce7919bc98a3a12453135df45dd8c52f877830..78568c90740baa68a8c0035ce3be8c7e6cbd7470 100644

--- a/extensions/test/data/data_sender_unittest.js

+++ b/extensions/test/data/data_sender_unittest.js

@@ -57,9 +57,9 @@ unittestBindings.exportTests([

function testLargeSend() {

createSender().then(test.callbackPass(function(sender) {

- sender.send(generateData(BUFFER_SIZE * 100, '1234567890')).then(

+ sender.send(generateData(BUFFER_SIZE * 3, '123')).then(

test.callbackPass(function(bytesSent) {

- test.assertEq(BUFFER_SIZE * 100, bytesSent);

+ test.assertEq(BUFFER_SIZE * 3, bytesSent);

sender.close();

}));

@@ -67,7 +67,7 @@ unittestBindings.exportTests([

function testSendError() {

createSender().then(test.callbackPass(function(sender) {

- sender.send(generateData(BUFFER_SIZE * 100, 'b')).catch(test.callbackPass(

+ sender.send(generateData(BUFFER_SIZE * 3, 'b')).catch(test.callbackPass(

function(e) {

test.assertEq(1, e.error);

test.assertEq(0, e.bytesSent);

@@ -82,7 +82,7 @@ unittestBindings.exportTests([

function testSendErrorPartialSuccess() {

createSender().then(test.callbackPass(function(sender) {

- sender.send(generateData(BUFFER_SIZE * 100, 'b')).catch(test.callbackPass(

+ sender.send(generateData(BUFFER_SIZE * 3, 'b')).catch(test.callbackPass(

function(e) {

test.assertEq(1, e.error);

test.assertEq(5, e.bytesSent);

@@ -134,7 +134,7 @@ unittestBindings.exportTests([

function testSendErrorInLargeSend() {

createSender().then(test.callbackPass(function(sender) {

- sender.send(generateData(BUFFER_SIZE * 100, '1234567890')).catch(

+ sender.send(generateData(BUFFER_SIZE * 3, '1234567890')).catch(

test.callbackPass(function(e) {

test.assertEq(1, e.error);

test.assertEq(12, e.bytesSent);

@@ -153,7 +153,7 @@ unittestBindings.exportTests([

test.assertEq(1, e.error);

test.assertEq(2, e.bytesSent);

}));

- sender.send(generateData(BUFFER_SIZE * 100, '1234567890')).catch(

+ sender.send(generateData(BUFFER_SIZE * 3, '1234567890')).catch(

test.callbackPass(function(e) {

test.assertEq(1, e.error);

test.assertEq(0, e.bytesSent);