Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 499133003: Further shorten the lastchange string. (Closed)

Created:
6 years, 4 months ago by agable
Modified:
6 years, 3 months ago
Reviewers:
cmp, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Further shorten the lastchange string. Even the 40-character hash causes problems when the pieces of the string before it push the length to >64 characters. Truncating it is a temporary fix until we discuss ways to accept strings longer than 64 chars. R=cmp@chromium.org, scottmg@chromium.org NOTRY=True BUG=406783 Committed: https://crrev.com/15a2a65986f6dec827cce5bc7d58601ed9b1eb2a Cr-Commit-Position: refs/heads/master@{#291626}

Patch Set 1 #

Patch Set 2 : Typo in comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/util/lastchange.py View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
agable
6 years, 4 months ago (2014-08-24 18:35:52 UTC) #1
cmp
lgtm
6 years, 4 months ago (2014-08-24 18:39:54 UTC) #2
agable
The CQ bit was checked by agable@chromium.org
6 years, 4 months ago (2014-08-24 18:40:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agable@chromium.org/499133003/20001
6 years, 4 months ago (2014-08-24 18:40:43 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (20001) as f292d1c2781fd2e4b9d0eaab79cddd908f548d21
6 years, 4 months ago (2014-08-24 18:41:17 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:32:36 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/15a2a65986f6dec827cce5bc7d58601ed9b1eb2a
Cr-Commit-Position: refs/heads/master@{#291626}

Powered by Google App Engine
This is Rietveld 408576698