build/util/lastchange.py - Issue 499133003: Further shorten the lastchange string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/util/lastchange.py

Issue 499133003: Further shorten the lastchange string. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Typo in comment Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/util/lastchange.py

diff --git a/build/util/lastchange.py b/build/util/lastchange.py

index 93c695845998eb47c268b467d41f4363299c555a..e938c3db70dcab21275520bc9b9e94c71a4ae8c7 100755

--- a/build/util/lastchange.py

+++ b/build/util/lastchange.py

@@ -109,7 +109,9 @@ def FetchGitRevision(directory):

hsh = output

if not hsh:

return None

- return VersionInfo('git', hsh)

+ # TODO(agable): Figure out a way to use the full hash instead of just a

+ # 12-character short hash. See crbug.com/406783.

+ return VersionInfo('git', hsh[:12])

def FetchGitSVNURLAndRevision(directory, svn_url_regex):

« no previous file with comments | « no previous file | no next file » | no next file with comments »