Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 499123002: Remove the old cache dir before moving the bootstrapped cache dir into the real location (Closed)

Created:
6 years, 4 months ago by hinoka
Modified:
6 years, 4 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Project:
tools
Visibility:
Public.

Description

Remove the old cache dir before moving the bootstrapped cache dir into the real location Seems like some combination of things (bad cache dir, shallow checkout, etc) causes git cache to not clean up properly before trying to move new directory A into already existing directory B. So the logic is all there to detect that the cache is invalid, its just not being cleaned up properly during shallow checkouts. BUG=406864 TBR=iannucci Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291587

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M git_cache.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ryan Tseng
6 years, 4 months ago (2014-08-24 11:57:32 UTC) #1
tandrii(chromium)
lgtm
6 years, 4 months ago (2014-08-24 11:59:42 UTC) #2
Ryan Tseng
The CQ bit was checked by hinoka@google.com
6 years, 4 months ago (2014-08-24 12:01:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@chromium.org/499123002/1
6 years, 4 months ago (2014-08-24 12:02:16 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-24 12:02:17 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-24 12:02:17 UTC) #6
Ryan Tseng
The CQ bit was checked by hinoka@google.com
6 years, 4 months ago (2014-08-24 12:06:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@chromium.org/499123002/1
6 years, 4 months ago (2014-08-24 12:07:15 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-24 12:09:15 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (1) as 291587

Powered by Google App Engine
This is Rietveld 408576698