git_cache.py - Issue 499123002: Remove the old cache dir before moving the bootstrapped cache dir into the real location

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cache.py

Issue 499123002: Remove the old cache dir before moving the bootstrapped cache dir into the real location (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git_cache.py

diff --git a/git_cache.py b/git_cache.py

index bfdef80d797431d12a3c922a0236ff6931e4875c..21252535f491146eea20efa32179144b8d469827 100755

--- a/git_cache.py

+++ b/git_cache.py

@@ -416,6 +416,8 @@ class Mirror(object):

finally:

if tempdir:

try:

+ if os.path.exists(self.mirror_path):

+ gclient_utils.rmtree(self.mirror_path)

os.rename(tempdir, self.mirror_path)

except OSError as e:

# This is somehow racy on Windows.

« no previous file with comments | « no previous file | no next file » | no next file with comments »