Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1416)

Issue 498903002: Updates compile targets for telemetry/nacl to include chrome_run (Closed)

Created:
6 years, 4 months ago by sky
Modified:
6 years, 4 months ago
Reviewers:
iannucci
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Project:
tools
Visibility:
Public.

Description

Updates compile targets for telemetry/nacl to include chrome_run This is needed for the filter step which returns chrome_run and not chrome. There is similar logic in SwarmingGTestTest. BUG=109173 TEST=none R=iannucci@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291608

Patch Set 1 #

Patch Set 2 : analyzer->filter #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -53 lines) Patch
M scripts/slave/recipe_modules/chromium/steps.py View 1 3 chunks +6 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/buildspec_compile_targets.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_10.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__32_.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__dbg_.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__dbg__32_.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder__dbg_.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder__dbg__32_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_Builder.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_Builder__dbg_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder__dbg_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_skia_Linux_Builder.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_skia_Mac_Builder.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/checklicenses_failure.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/checkperms_failure.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_matching_exclusion.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_first_failure_linux.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/deapply_compile_failure_linux.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/dont_analyze_for_non_src_project.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_clang_dbg.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_clang_rel.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_dbg.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_ozone_dbg.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_ozone_rel.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_rel.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_rel_swarming.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_clang_dbg.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_clang_rel.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_compile_dbg.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_compile_dbg_32.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_compile_rel.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_dbg.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_rel.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_rel_ng.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_rel_swarming.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_trusty32_dbg.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_trusty32_rel.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_trusty_dbg.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_trusty_rel.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_no_bot_update.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_compile_dbg.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_compile_rel.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_dbg.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_openssl_dbg.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_openssl_rel.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_rel.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_rel_swarming.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/invalid_json_without_patch.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/mojo_python_tests_failure.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_basic_try_job.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_deapply_patch.json View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_missing_isolated.json View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
sky
6 years, 4 months ago (2014-08-22 22:16:02 UTC) #1
iannucci
LGTM
6 years, 4 months ago (2014-08-25 18:37:11 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 4 months ago (2014-08-25 19:02:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/498903002/20001
6 years, 4 months ago (2014-08-25 19:03:09 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-25 19:03:50 UTC) #5
commit-bot: I haz the power
Presubmit check for 498903002-20001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 4 months ago (2014-08-25 19:03:51 UTC) #6
sky
The CQ bit was checked by sky@chromium.org
6 years, 4 months ago (2014-08-25 19:12:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/498903002/40001
6 years, 4 months ago (2014-08-25 19:13:12 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-25 19:14:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (40001) as 291608

Powered by Google App Engine
This is Rietveld 408576698