Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: scripts/slave/recipe_modules/chromium/steps.py

Issue 498903002: Updates compile targets for telemetry/nacl to include chrome_run (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: merge Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium.expected/buildspec_compile_targets.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium/steps.py
diff --git a/scripts/slave/recipe_modules/chromium/steps.py b/scripts/slave/recipe_modules/chromium/steps.py
index ce27f33a60c97d5869403a0241e59ff55e2e7ca3..b7738e0d5e17accb1649b89fe84acd9b0af056f2 100644
--- a/scripts/slave/recipe_modules/chromium/steps.py
+++ b/scripts/slave/recipe_modules/chromium/steps.py
@@ -538,7 +538,8 @@ class TelemetryUnitTests(PythonBasedTest): # pylint: disable=W0232
@staticmethod
def compile_targets(_):
- return ['chrome']
+ # Include chrome_run as filter picks up chrome and not chrome_run.
+ return ['chrome', 'chrome_run']
def run_step(self, api, suffix, cmd_args, **kwargs):
return api.chromium.run_telemetry_unittests(suffix, cmd_args, **kwargs)
@@ -549,7 +550,8 @@ class TelemetryPerfUnitTests(PythonBasedTest):
@staticmethod
def compile_targets(_):
- return ['chrome']
+ # Include chrome_run as filter picks up chrome and not chrome_run.
+ return ['chrome', 'chrome_run']
def run_step(self, api, suffix, cmd_args, **kwargs):
return api.chromium.run_telemetry_perf_unittests(suffix, cmd_args,
@@ -561,7 +563,8 @@ class NaclIntegrationTest(Test): # pylint: disable=W0232
@staticmethod
def compile_targets(_):
- return ['chrome']
+ # Include chrome_run as filter picks up chrome and not chrome_run.
+ return ['chrome', 'chrome_run']
def run(self, api, suffix):
args = [
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium.expected/buildspec_compile_targets.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698