Issue 498773004: Fix confusion between length in bytes and length in characters in app::response().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 498773004: Fix confusion between length in bytes and length in characters in app::response(). (Closed)

Created:
6 years, 4 months ago by Tom Sepez

Modified:
6 years, 4 months ago

Reviewers:
jun_fang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Visibility:
Public.

Fix confusion between length in bytes and length in characters in app::response(). I also clean up the code while we are here, rewriting a strange switch statement and tidying whitespace. BUG=406142 R=jun_fang@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/48f26c5

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -27 lines)			Patch
	M	fpdfsdk/src/javascript/app.cpp	View	1	2 chunks	+17 lines, -27 lines	0 comments	Download

Total messages: 3 (0 generated)

jun_fang

On 2014/08/22 19:58:09, Tom Sepez wrote: > Jun, please review. LGTM. Thanks!

6 years, 4 months ago (2014-08-22 22:33:06 UTC) #2

Tom Sepez

6 years, 4 months ago (2014-08-22 22:52:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as 48f26c5 (presubmit successful).