Fix confusion between length in bytes and length in characters in app::response().

fpdfsdk/src/javascript/app.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/javascript/JavaScript.h"
 #include "../../include/javascript/IJavaScript.h"
 #include "../../include/javascript/JS_Define.h"
 #include "../../include/javascript/JS_Object.h"
@@ skipping 1027 matching lines @@
         CFX_WideString swDefault = L"";
         bool bPassWord = false;
 
         v8::Isolate* isolate = GetIsolate(cc);
 
         int iLength = params.size();
         if (iLength > 0 && params[0].GetType() == VT_object)
         {
                 JSObject pObj = (JSObject )params[0];
                 v8::Handle<v8::Value> pValue = JS_GetObjectElement(isolate,pObj,L"cQuestion");
-                        swQuestion = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).operator CFX_WideString();
+                swQuestion = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).operator CFX_WideString();
 
                 pValue = JS_GetObjectElement(isolate,pObj,L"cTitle");
-                        swTitle = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).operator CFX_WideString();
+                swTitle = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).operator CFX_WideString();
 
                 pValue = JS_GetObjectElement(isolate,pObj,L"cDefault");
-                        swDefault = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).operator CFX_WideString();
+                swDefault = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).operator CFX_WideString();
 
                 pValue = JS_GetObjectElement(isolate,pObj,L"cLabel");
-                        swLabel = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).operator CFX_WideString();
+                swLabel = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).operator CFX_WideString();
 
                 pValue = JS_GetObjectElement(isolate,pObj,L"bPassword");
-                        bPassWord = (bool)CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue));
+                bPassWord = (bool)CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue));
         }
         else
         {
                 switch(iLength)
                 {
+                case 5:
+                        swLabel = params[4];
+                        // FALLTHROUGH
+                case 4:
+                        bPassWord = params[3];
+                        // FALLTHROUGH
+                case 3:
+                        swDefault = params[2];
+                        // FALLTHROUGH
+                case 2:
+                        swTitle = params[1];
+                        // FALLTHROUGH
                 case 1:
                         swQuestion = params[0];
-                        break;
-                case 2:
-                        swQuestion = params[0];
-                        swTitle = params[1];
-                        break;
-                case 3:
-                        swQuestion = params[0];
-                        swTitle = params[1];
-                        swDefault = params[2];
-                        break;
-                case 4:
-                        swQuestion = params[0];
-                        swTitle = params[1];
-                        swDefault = params[2];
-                        bPassWord = params[3];
-                        break;
-                case 5:
-                        swQuestion = params[0];
-                        swTitle = params[1];
-                        swDefault = params[2];
-                        bPassWord = params[3];
-                        swLabel = params[4];
-                        break;
+                        // FALLTHROUGH
                 default:
                         break;
                 }
         }
 
         CJS_Context* pContext = (CJS_Context *)cc;
         ASSERT(pContext != NULL);
 
         CPDFDoc_Environment* pApp = pContext->GetReaderApp();
         ASSERT(pApp != NULL);
 
         const int MAX_INPUT_BYTES = 2048;
         char* pBuff = new char[MAX_INPUT_BYTES + 2];
         if (!pBuff)
                 return FALSE;
 
         memset(pBuff, 0, MAX_INPUT_BYTES + 2);
         int nLengthBytes = pApp->JS_appResponse(swQuestion, swTitle, swDefault, swLabel, bPassWord, pBuff, MAX_INPUT_BYTES);
         if (nLengthBytes <= 0)
         {
                 vRet.SetNull();
                 delete[] pBuff;
                 return FALSE;
         }
         if (nLengthBytes > MAX_INPUT_BYTES)
                 nLengthBytes = MAX_INPUT_BYTES;
 
-        vRet = CFX_WideString::FromUTF16LE((unsigned short*)pBuff, nLengthBytes);
+        vRet = CFX_WideString::FromUTF16LE((unsigned short*)pBuff, nLengthBytes / sizeof(unsigned short));
         delete[] pBuff;
         return TRUE;
 }
 
 FX_BOOL app::media(OBJ_PROP_PARAMS)
 {
         return FALSE;
 }
 
 FX_BOOL app::execDialog(OBJ_METHOD_PARAMS)
 {
         return TRUE;
 }