Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 498553004: Remove implicit conversions from scoped_refptr to T* in content/browser/loader/ (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
mmenke
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/67769df5422bdf01a8d4a21f18fed694bec03647 Cr-Commit-Position: refs/heads/master@{#291968}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M content/browser/loader/cross_site_resource_handler.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/loader/detachable_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M content/browser/loader/resource_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/resource_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/temporary_file_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/upload_data_stream_builder_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + mmenke@chromium.org
6 years, 3 months ago (2014-08-26 17:13:31 UTC) #1
dcheng
Unfortunately, we can't make scoped_refptr testable until the conversion operator has been removed. While it ...
6 years, 3 months ago (2014-08-26 17:13:31 UTC) #2
mmenke
LGT! A bit unfortunate we have to do this, but definitely worth it to get ...
6 years, 3 months ago (2014-08-26 17:19:43 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-26 17:20:30 UTC) #4
dcheng
The CQ bit was unchecked by dcheng@chromium.org
6 years, 3 months ago (2014-08-26 17:20:45 UTC) #5
dcheng
On 2014/08/26 at 17:19:43, mmenke wrote: > LGT! A bit unfortunate we have to do ...
6 years, 3 months ago (2014-08-26 17:21:12 UTC) #6
mmenke
On 2014/08/26 17:21:12, dcheng (OOO) wrote: > On 2014/08/26 at 17:19:43, mmenke wrote: > > ...
6 years, 3 months ago (2014-08-26 17:51:01 UTC) #7
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-26 17:51:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/498553004/1
6 years, 3 months ago (2014-08-26 17:52:25 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-26 19:01:15 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 19:44:18 UTC) #11
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-26 19:44:20 UTC) #12
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-26 19:46:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/498553004/1
6 years, 3 months ago (2014-08-26 19:46:50 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 19:48:27 UTC) #15
commit-bot: I haz the power
Failed to apply patch for content/browser/loader/cross_site_resource_handler.cc: While running git apply --index -p1; error: patch failed: ...
6 years, 3 months ago (2014-08-26 19:48:29 UTC) #16
dcheng
As far as I can tell, this successfully committed in https://crrev.com/67769df5422bdf01a8d4a21f18fed694bec03647 despite saying 'failed to ...
6 years, 3 months ago (2014-08-26 19:58:36 UTC) #17
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:45:10 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67769df5422bdf01a8d4a21f18fed694bec03647
Cr-Commit-Position: refs/heads/master@{#291968}

Powered by Google App Engine
This is Rietveld 408576698