content/browser/loader/detachable_resource_handler.cc - Issue 498553004: Remove implicit conversions from scoped_refptr to T* in content/browser/loader/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/detachable_resource_handler.cc

Issue 498553004: Remove implicit conversions from scoped_refptr to T* in content/browser/loader/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/loader/cross_site_resource_handler.cc ('k') | content/browser/loader/resource_dispatcher_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/detachable_resource_handler.cc

diff --git a/content/browser/loader/detachable_resource_handler.cc b/content/browser/loader/detachable_resource_handler.cc

index 1fe9f0624d06597b35d85dd2b2451d6eaa9133e6..4b0641b30fc7dcdbec634593361b8bd82ed75637 100644

--- a/content/browser/loader/detachable_resource_handler.cc

+++ b/content/browser/loader/detachable_resource_handler.cc

@@ -146,7 +146,7 @@ bool DetachableResourceHandler::OnWillRead(scoped_refptr<net::IOBuffer>* buf,

int min_size) {

if (!next_handler_) {

DCHECK_EQ(-1, min_size);

- if (!read_buffer_)

+ if (!read_buffer_.get())

read_buffer_ = new net::IOBuffer(kReadBufSize);

*buf = read_buffer_;

*buf_size = kReadBufSize;

« no previous file with comments | « content/browser/loader/cross_site_resource_handler.cc ('k') | content/browser/loader/resource_dispatcher_host_impl.cc » ('j') | no next file with comments »