Tools/GardeningServer/model/ct-failure.html - Issue 498523002: [Sheriff-o-matic] Use likely_revisions instead of first_failing/last_passing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/GardeningServer/model/ct-failure.html

Issue 498523002: [Sheriff-o-matic] Use likely_revisions instead of first_failing/last_passing (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: sort git hashes Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Tools/GardeningServer/model/ct-commit-log.html ('K') | « Tools/GardeningServer/model/ct-commit-log-mock.html ('k') | Tools/GardeningServer/model/ct-failure-group.html » ('j') | Tools/GardeningServer/model/ct-failure-group.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/GardeningServer/model/ct-failure.html

diff --git a/Tools/GardeningServer/model/ct-failure.html b/Tools/GardeningServer/model/ct-failure.html

index b91363b468b0b09e1dc64c279bfd8287c060b8c0..14b2696eb0c965bdfbf80c1641071cec3cc26155 100644

--- a/Tools/GardeningServer/model/ct-failure.html

+++ b/Tools/GardeningServer/model/ct-failure.html

@@ -5,14 +5,11 @@ found in the LICENSE file.

-->

-function CTFailure(step, reason, resultsByBuilder, firstFailingRevisions, lastPassingRevisions) {

+function CTFailure(step, reason, resultsByBuilder) {

this.step = step;

// FIXME: Rename this to reason.

this.testName = reason;

this.resultNodesByBuilder = resultsByBuilder;

- // FIXME: Move these up one layer to the groupedFailures object.

ojan 2014/08/23 01:23:05 Yay!

Mathieu 2014/08/24 23:42:11 Acknowledged.

- this.firstFailingRevisions = firstFailingRevisions;

- this.lastPassingRevisions = lastPassingRevisions;

}

CTFailure.prototype.flakinessDashboardURL = function(tree) {