Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <!-- | 1 <!-- |
| 2 Copyright 2014 The Chromium Authors. All rights reserved. | 2 Copyright 2014 The Chromium Authors. All rights reserved. |
| 3 Use of this source code is governed by a BSD-style license that can be | 3 Use of this source code is governed by a BSD-style license that can be |
| 4 found in the LICENSE file. | 4 found in the LICENSE file. |
| 5 --> | 5 --> |
| 6 | 6 |
| 7 <script> | 7 <script> |
| 8 function CTFailure(step, reason, resultsByBuilder, firstFailingRevisions, lastPa ssingRevisions) { | 8 function CTFailure(step, reason, resultsByBuilder) { |
| 9 this.step = step; | 9 this.step = step; |
| 10 // FIXME: Rename this to reason. | 10 // FIXME: Rename this to reason. |
| 11 this.testName = reason; | 11 this.testName = reason; |
| 12 this.resultNodesByBuilder = resultsByBuilder; | 12 this.resultNodesByBuilder = resultsByBuilder; |
| 13 // FIXME: Move these up one layer to the groupedFailures object. | |
|
ojan
2014/08/23 01:23:05
Yay!
Mathieu
2014/08/24 23:42:11
Acknowledged.
| |
| 14 this.firstFailingRevisions = firstFailingRevisions; | |
| 15 this.lastPassingRevisions = lastPassingRevisions; | |
| 16 } | 13 } |
| 17 | 14 |
| 18 CTFailure.prototype.flakinessDashboardURL = function(tree) { | 15 CTFailure.prototype.flakinessDashboardURL = function(tree) { |
| 19 var testType = this.step; | 16 var testType = this.step; |
| 20 | 17 |
| 21 // FIXME: Replace the flakiness dashboard's sense of groups with sheriff-o-mat ic's | 18 // FIXME: Replace the flakiness dashboard's sense of groups with sheriff-o-mat ic's |
| 22 // sense of trees and get rid of this mapping. | 19 // sense of trees and get rid of this mapping. |
| 23 var treeToDashboardGroup = { | 20 var treeToDashboardGroup = { |
| 24 blink: '@ToT%20Blink', | 21 blink: '@ToT%20Blink', |
| 25 chromium: '@ToT%20Chromium', | 22 chromium: '@ToT%20Chromium', |
| (...skipping 19 matching lines...) Expand all Loading... | |
| 45 } | 42 } |
| 46 | 43 |
| 47 CTFailure.prototype.reasonGroupName = function() { | 44 CTFailure.prototype.reasonGroupName = function() { |
| 48 if (!this.testName) | 45 if (!this.testName) |
| 49 return undefined; | 46 return undefined; |
| 50 if (this.step == 'webkit_tests') | 47 if (this.step == 'webkit_tests') |
| 51 return this.testName.substr(0, this.testName.lastIndexOf('/')); | 48 return this.testName.substr(0, this.testName.lastIndexOf('/')); |
| 52 return this.testName.substr(0, this.testName.lastIndexOf('.')); | 49 return this.testName.substr(0, this.testName.lastIndexOf('.')); |
| 53 }; | 50 }; |
| 54 </script> | 51 </script> |
| OLD | NEW |