Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: Tools/GardeningServer/ui/test/ct-failure-analyzer-tests.html

Issue 498523002: [Sheriff-o-matic] Use likely_revisions instead of first_failing/last_passing (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase + no sort Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/test/ct-failure-analyzer-tests.html
diff --git a/Tools/GardeningServer/ui/test/ct-failure-analyzer-tests.html b/Tools/GardeningServer/ui/test/ct-failure-analyzer-tests.html
index ecb46d37104824d056bc51a561e756b855cc9e7d..484cace08f5d6481ace65f0b65ba27d7abb1e8de 100644
--- a/Tools/GardeningServer/ui/test/ct-failure-analyzer-tests.html
+++ b/Tools/GardeningServer/ui/test/ct-failure-analyzer-tests.html
@@ -30,45 +30,33 @@ describe('ct-failure-analyzer', function() {
describe('_failureListComparator', function() {
it('should compare failures correctly', function() {
var analyzer = document.createElement('ct-failure-analyzer');
- var revision1 = {
- 'chromium': 1,
- 'blink': 2
- };
- var revision2 = {
- 'chromium': 2,
- 'blink': 1
- };
- var revision3 = {
- 'chromium': 2,
- 'blink': 2
- };
- var resultsByBuilder = {};
- var failure1 = new CTFailure("step", "reason", resultsByBuilder, revision1, revision1);
- var failure2 = new CTFailure("step", "reason", resultsByBuilder, revision2, revision2);
- var failure3 = new CTFailure("step", "reason", resultsByBuilder, revision3, revision3);
- var failure4 = new CTFailure("step", "reason", resultsByBuilder, null, null);
- var group1 = new CTFailureGroup([failure1], null);
- var group2 = new CTFailureGroup([failure2], null);
- var group3 = new CTFailureGroup([failure3], null);
- var group4 = new CTFailureGroup([failure4], null);
+
+ var cl1 = new CTCommitList(undefined, ['chromium:1', 'blink:2']);
+ var cl2 = new CTCommitList(undefined, ['chromium:2', 'blink:1']);
+ var cl3 = new CTCommitList(undefined, ['chromium:2', 'blink:2']);
+ var cl4 = new CTCommitList(undefined, []);
+ var group1 = new CTFailureGroup([], cl1);
+ var group2 = new CTFailureGroup([], cl2);
+ var group3 = new CTFailureGroup([], cl3);
+ var group4 = new CTFailureGroup([], cl4);
// Sort by last revision first.
- assert(analyzer._failureListComparator('chromium', group1, group2) > 0);
- assert(analyzer._failureListComparator('chromium', group2, group1) < 0);
- assert(analyzer._failureListComparator('chromium', group1, group1) == 0);
+ assert(analyzer._failureByTreeListComparator('chromium', group1, group2) > 0);
+ assert(analyzer._failureByTreeListComparator('chromium', group2, group1) < 0);
+ assert(analyzer._failureByTreeListComparator('chromium', group1, group1) == 0);
// If the tree revisions are equal, take others.
- assert(analyzer._failureListComparator('chromium', group2, group3) > 0);
+ assert(analyzer._failureByTreeListComparator('chromium', group2, group3) > 0);
// Prioritize the given tree.
- assert(analyzer._failureListComparator('chromium', group1, group2) > 0);
- assert(analyzer._failureListComparator('blink', group1, group2) < 0);
+ assert(analyzer._failureByTreeListComparator('chromium', group1, group2) > 0);
+ assert(analyzer._failureByTreeListComparator('blink', group1, group2) < 0);
// Default to 'chromium'.
- assert(analyzer._failureListComparator(undefined, group1, group2) > 0);
+ assert(analyzer._failureByTreeListComparator(undefined, group1, group2) > 0);
// Failures without a revision go to the end.
- assert(analyzer._failureListComparator('chromium', group4, group1) < 0);
+ assert(analyzer._failureByTreeListComparator('chromium', group4, group1) > 0);
});
});
});
« no previous file with comments | « Tools/GardeningServer/ui/test/ct-commit-list-tests.html ('k') | Tools/GardeningServer/ui/test/ct-failure-card-tests.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698