Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2081)

Unified Diff: Tools/GardeningServer/ui/test/ct-failure-card-tests.html

Issue 498523002: [Sheriff-o-matic] Use likely_revisions instead of first_failing/last_passing (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase + no sort Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/test/ct-failure-card-tests.html
diff --git a/Tools/GardeningServer/ui/test/ct-failure-card-tests.html b/Tools/GardeningServer/ui/test/ct-failure-card-tests.html
index 37a501f4c67c44d43c290a8f335585b35bb048b9..e60baee3df35d115e3b91c0cc0aab867f866e60f 100644
--- a/Tools/GardeningServer/ui/test/ct-failure-card-tests.html
+++ b/Tools/GardeningServer/ui/test/ct-failure-card-tests.html
@@ -6,6 +6,7 @@ found in the LICENSE file.
<link rel="import" href="../ct-failure-card.html">
+<link rel="import" href="../../model/ct-commit-list-mock.html">
<link rel="import" href="../../model/ct-commit-log-mock.html">
<link rel="import" href="../../model/ct-failure-group.html">
@@ -21,9 +22,10 @@ describe('ct-failure-card', function() {
beforeEach(function(done) {
card = document.createElement('ct-failure-card');
+ var cl = new CTCommitListMock();
group = new CTFailureGroup([
new CTFailure('autobot', 'unknown', {someBuilder: {key: 'a'}}, {'blink':158547},
- {'blink':158544})]);
+ {'blink':158544})], cl);
card.group = group;
card.commitLog = new CTCommitLogMock();
setTimeout(done);
@@ -33,20 +35,20 @@ describe('ct-failure-card', function() {
it('should have commit summaries', function(done) {
// Expand the first repository so that the <ct-commit>'s are generated.
- card._commitList.repositories[0].expanded = true;
+ card.group.commitList.repositories[0].expanded = true;
setTimeout(function() {
var list = card.shadowRoot.querySelector('ct-commit-list');
var commits = list.shadowRoot.querySelectorAll('ct-commit');
- assert(commits[0].data);
- assert(commits[0].data.summary);
+ assert(commits[1].data);
+ assert(commits[1].data.summary);
done();
});
});
it('removing a commit summary', function(done) {
card.commitLog.commits['blink']['158545'].summary = undefined;
- card._commitList.repositories[0].expanded = true;
+ card.group.commitList.repositories[0].expanded = true;
setTimeout(function() {
var list = card.shadowRoot.querySelector('ct-commit-list');

Powered by Google App Engine
This is Rietveld 408576698