Issue 498473002: bisect-builds.py: Fix official build bisect for Windows platform.

Issue 498473002: bisect-builds.py: Fix official build bisect for Windows platform. (Closed)

Created:
6 years, 4 months ago by pshenoy

Modified:
6 years, 4 months ago

Reviewers:
DaleCurtis

CC:
chromium-reviews, anantha

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

bisect-builds.py: Fix official build bisect for Windows platform. BUG=None NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291142

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tools/bisect-builds.py	View	1	3 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

DaleCurtis

Does mac need to be fixed too? lgtm % nit. https://codereview.chromium.org/498473002/diff/1/tools/bisect-builds.py File tools/bisect-builds.py (right): https://codereview.chromium.org/498473002/diff/1/tools/bisect-builds.py#newcode450 ...

6 years, 4 months ago (2014-08-21 18:24:00 UTC) #2

pshenoy

No. Mac is fine. https://codereview.chromium.org/498473002/diff/1/tools/bisect-builds.py File tools/bisect-builds.py (right): https://codereview.chromium.org/498473002/diff/1/tools/bisect-builds.py#newcode450 tools/bisect-builds.py:450: i = 0 On 2014/08/21 ...

6 years, 4 months ago (2014-08-21 18:34:50 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pshenoy@chromium.org/498473002/20001

6 years, 4 months ago (2014-08-21 18:38:24 UTC) #5

commit-bot: I haz the power

6 years, 4 months ago (2014-08-21 18:41:29 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (20001) as 291142

Expand Messages | Collapse Messages