Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: tools/bisect-builds.py

Issue 498473002: bisect-builds.py: Fix official build bisect for Windows platform. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bisect-builds.py
diff --git a/tools/bisect-builds.py b/tools/bisect-builds.py
index dd51cc94dfed057e761fe7c23549e717cdc5e2cc..9d0d7bace809f3e8c3d47d7cbc3e0af1a75dc269 100755
--- a/tools/bisect-builds.py
+++ b/tools/bisect-builds.py
@@ -158,6 +158,8 @@ class PathContext(object):
self._binary_name = 'Google Chrome.app/Contents/MacOS/Google Chrome'
elif self.platform == 'win':
self._listing_platform_dir = 'win/'
+ self.archive_name = 'chrome-win.zip'
+ self._archive_extract_dir = 'chrome-win'
else:
if self.platform in ('linux', 'linux64', 'linux-arm'):
self.archive_name = 'chrome-linux.zip'
@@ -445,7 +447,6 @@ class PathContext(object):
revision_re = re.compile(r'(\d\d\.\d\.\d{4}\.\d+)')
build_numbers = filter(lambda b: revision_re.search(b), build_numbers)
final_list = []
- i = 0
parsed_build_numbers = [LooseVersion(x) for x in build_numbers]
connection = httplib.HTTPConnection(GOOGLE_APIS_URL)
for build_number in sorted(parsed_build_numbers):
@@ -455,7 +456,6 @@ class PathContext(object):
continue
path = ('/' + GS_BUCKET_NAME + '/' + str(build_number) + '/' +
self._listing_platform_dir + self.archive_name)
- i = i + 1
connection.request('HEAD', path)
response = connection.getresponse()
if response.status == 200:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698